Skip to content

Fix the toc tool to insert the toc#3225

Merged
jathak merged 1 commit intosass:mainfrom
stof:fix_toc
Jan 14, 2022
Merged

Fix the toc tool to insert the toc#3225
jathak merged 1 commit intosass:mainfrom
stof:fix_toc

Conversation

@stof
Copy link
Contributor

@stof stof commented Dec 27, 2021

When the file contains an existing TOC title without its content, the logic at

if (currentToc === null) {
was failing due to returning an empty string rather than null

@jathak jathak self-requested a review January 14, 2022 01:56
@jathak jathak merged commit 4f42632 into sass:main Jan 14, 2022
@stof stof deleted the fix_toc branch January 17, 2022 08:10
mirisuzanne pushed a commit that referenced this pull request Feb 10, 2022
mirisuzanne added a commit that referenced this pull request Feb 10, 2022
* main: (149 commits)
  Add the sourceMapIncludeSources option in the new JS API (#3226)
  Fix the toc tool to insert the toc (#3225)
  Fix some incorrect documentation/typings in LegacyPluginThis.options (#3246)
  Add a type annotation for the top-level NULL field (#3243)
  Add type annotations for the top-level TRUE and FALSE fields (#3241)
  Add type annotations for the sass.types.Error class (#3238)
  Add a type declaration for LegacyPluginThis.options.context (#3236)
  Make LegacyAsyncFunction type more usable (#3237)
  Allow SassFunction signatures to be checked on return (#3220)
  Make LegacyFileOptions.data optional (#3215)
  Use the URL type from the DOM definitions, not from Node (#3214)
  Document the new JS API (#3183)
  Make the new JS API a bit more idiomatic (#3200)
  Update immutable-js dep. (#3195)
  Add a code example for Logger.silent (#3192)
  Update dependencies (#3193)
  Replace FileImporterResult with a plain URL (#3180)
  Convert explicit compatiblity HTML into a nicer @-tag
  Convert explicit "Heads up" HTML into nicer-looking Markdown
  Automatically handle absolute file: URLs for FileImporters (#3181)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants