Skip to content

Use the URL type from the DOM definitions, not from Node#3214

Merged
nex3 merged 1 commit intomainfrom
dom-url
Dec 10, 2021
Merged

Use the URL type from the DOM definitions, not from Node#3214
nex3 merged 1 commit intomainfrom
dom-url

Conversation

@nex3
Copy link
Contributor

@nex3 nex3 commented Dec 10, 2021

The two aren't quite interchangeable: the Node definition has a few
more fields, which means that URLs created naively with new URL()
aren't assignable to that type.

The two aren't quite interchangeable: the Node definition has a few
more fields, which means that URLs created naively with `new URL()`
aren't assignable to that type.
@nex3 nex3 requested a review from jathak December 10, 2021 03:55
@nex3 nex3 merged commit 23278f2 into main Dec 10, 2021
@nex3 nex3 deleted the dom-url branch December 10, 2021 21:11
mirisuzanne pushed a commit that referenced this pull request Feb 10, 2022
The two aren't quite interchangeable: the Node definition has a few
more fields, which means that URLs created naively with `new URL()`
aren't assignable to that type.
mirisuzanne added a commit that referenced this pull request Feb 10, 2022
* main: (149 commits)
  Add the sourceMapIncludeSources option in the new JS API (#3226)
  Fix the toc tool to insert the toc (#3225)
  Fix some incorrect documentation/typings in LegacyPluginThis.options (#3246)
  Add a type annotation for the top-level NULL field (#3243)
  Add type annotations for the top-level TRUE and FALSE fields (#3241)
  Add type annotations for the sass.types.Error class (#3238)
  Add a type declaration for LegacyPluginThis.options.context (#3236)
  Make LegacyAsyncFunction type more usable (#3237)
  Allow SassFunction signatures to be checked on return (#3220)
  Make LegacyFileOptions.data optional (#3215)
  Use the URL type from the DOM definitions, not from Node (#3214)
  Document the new JS API (#3183)
  Make the new JS API a bit more idiomatic (#3200)
  Update immutable-js dep. (#3195)
  Add a code example for Logger.silent (#3192)
  Update dependencies (#3193)
  Replace FileImporterResult with a plain URL (#3180)
  Convert explicit compatiblity HTML into a nicer @-tag
  Convert explicit "Heads up" HTML into nicer-looking Markdown
  Automatically handle absolute file: URLs for FileImporters (#3181)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants