Automatically handle absolute file: URLs for FileImporters#3181
Merged
Conversation
nex3
added a commit
to sass/sass-spec
that referenced
this pull request
Oct 6, 2021
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Oct 6, 2021
Absolute file: URLs are always unambiguous when referring to the native filesystem, so there's no need for the custom callback to handle them. What's more, allowing the callback to only ever have to think about relative URLs will make it much simpler for users to implement.
11bfe57 to
9175a33
Compare
Awjin
approved these changes
Oct 7, 2021
nex3
added a commit
to sass/sass-spec
that referenced
this pull request
Oct 7, 2021
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Oct 7, 2021
nex3
added a commit
to sass/sass-spec
that referenced
this pull request
Oct 9, 2021
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Oct 9, 2021
nex3
added a commit
to sass/sass-spec
that referenced
this pull request
Oct 9, 2021
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Oct 13, 2021
nex3
added a commit
to sass/sass-spec
that referenced
this pull request
Oct 13, 2021
mirisuzanne
pushed a commit
that referenced
this pull request
Feb 10, 2022
Absolute file: URLs are always unambiguous when referring to the native filesystem, so there's no need for the custom callback to handle them. What's more, allowing the callback to only ever have to think about relative URLs will make it much simpler for users to implement.
mirisuzanne
added a commit
that referenced
this pull request
Feb 10, 2022
* main: (149 commits) Add the sourceMapIncludeSources option in the new JS API (#3226) Fix the toc tool to insert the toc (#3225) Fix some incorrect documentation/typings in LegacyPluginThis.options (#3246) Add a type annotation for the top-level NULL field (#3243) Add type annotations for the top-level TRUE and FALSE fields (#3241) Add type annotations for the sass.types.Error class (#3238) Add a type declaration for LegacyPluginThis.options.context (#3236) Make LegacyAsyncFunction type more usable (#3237) Allow SassFunction signatures to be checked on return (#3220) Make LegacyFileOptions.data optional (#3215) Use the URL type from the DOM definitions, not from Node (#3214) Document the new JS API (#3183) Make the new JS API a bit more idiomatic (#3200) Update immutable-js dep. (#3195) Add a code example for Logger.silent (#3192) Update dependencies (#3193) Replace FileImporterResult with a plain URL (#3180) Convert explicit compatiblity HTML into a nicer @-tag Convert explicit "Heads up" HTML into nicer-looking Markdown Automatically handle absolute file: URLs for FileImporters (#3181) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Absolute
file:URLs are always unambiguous when referring to the nativefilesystem, so there's no need for the custom callback to handle them.
What's more, allowing the callback to only ever have to think about
relative URLs will make it much simpler for users to implement.