Alleviate the need for ecosystem-wide upgrading to 0.4.1#74
Merged
Lokathor merged 2 commits intorust-windowing:semver-trickfrom Nov 23, 2021
Merged
Alleviate the need for ecosystem-wide upgrading to 0.4.1#74Lokathor merged 2 commits intorust-windowing:semver-trickfrom
Lokathor merged 2 commits intorust-windowing:semver-trickfrom
Conversation
Uses the semver trick, see https://github.com/dtolnay/semver-trick The idea is that this will allow crates whose purpose is to provide an `HasRawWindowHandle` implementation to upgrade first (e.g. `winit`, `sdl2`, `glfw`, `fltk`, ...). When a sufficient amount of "provider" crates have upgraded, "consumer" crates (e.g. `gfx`, `wgpu`, `rfd`, ...) can safely start upgrading without breaking for downstream users.
Member
Author
|
It would be helpful if someone could create a |
8 tasks
Member
|
I hope this was what you wanted :) |
madsmtm
commented
Nov 19, 2021
|
|
||
| [dependencies] | ||
| libc = {version="0.2", features=[]} | ||
| new = { version = "0.4.1", package = "raw-window-handle" } |
Member
Author
There was a problem hiding this comment.
Not sure if this, or by using extern crate raw_window_handle as new; is the most robust way to rename a crate?
Member
Author
|
If you agree that this is desirable, I'm thinking the way forward is to:
|
Lokathor
approved these changes
Nov 21, 2021
Contributor
|
This all seems like a good idea, but i've never done the semver trick thing before. First, I should just merge this, right? |
Member
Author
|
Well, I haven't done it before either, but I'm fairly certain it will work, so yes, merge this and make a release It should be noted that adding blanket implementations of |
Contributor
|
Okay, i'll merge this now then. |
Merged
madsmtm
added a commit
to madsmtm/winit
that referenced
this pull request
Nov 27, 2021
madsmtm
added a commit
to madsmtm/winit
that referenced
this pull request
Nov 27, 2021
msiglreith
pushed a commit
to rust-windowing/winit
that referenced
this pull request
Nov 30, 2021
* Update raw-window-handle to `0.4.2` See: - rust-windowing/raw-window-handle#72 - rust-windowing/raw-window-handle#73 - rust-windowing/raw-window-handle#74 * Clean up raw_window_handle functions a bit
MarijnS95
added a commit
to ash-rs/ash
that referenced
this pull request
Jan 10, 2022
`raw-window-handle 0.3.4` was pushed as a "semver-trick-like" patch release, implementing the `0.3` trait for the `0.4` crate release [74]. This allows `ash-window` as a window-handle "consumer" crate to accept both `0.3` and `0.4` handles from consumer crates simultaneously. To ensure this patch release is available even when users omit regular `cargo update` or build with `-Z minimal-versions`, set the minimal patch version in `Cargo.toml` to it. [74]: rust-windowing/raw-window-handle#74
Ralith
pushed a commit
to ash-rs/ash
that referenced
this pull request
Jan 10, 2022
#553) `raw-window-handle 0.3.4` was pushed as a "semver-trick-like" patch release, implementing the `0.3` trait for the `0.4` crate release [74]. This allows `ash-window` as a window-handle "consumer" crate to accept both `0.3` and `0.4` handles from consumer crates simultaneously. To ensure this patch release is available even when users omit regular `cargo update` or build with `-Z minimal-versions`, set the minimal patch version in `Cargo.toml` to it. [74]: rust-windowing/raw-window-handle#74
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is opened againstmaster, but in reality it should be merged into 5207e99.Using the semver trick, we can make upgrading from
0.3to0.4.1much less painful!We simply add a
v0.3HasRawWindowHandleimpl for av0.4.1HasRawWindowHandle, and releasev0.3.4.The idea is that this will allow crates whose purpose is to provide an
HasRawWindowHandleimplementation to upgrade first (e.g.winit,sdl2,glfw,fltk, ...). When a sufficient amount of "provider" crates have upgraded, "consumer" crates (e.g.gfx,wgpu,rfd, ...) can safely start upgrading while minimizing breakage for downstream users.