Skip to content

ash-window: Require at least raw-window-handle 0.3.4 for 0.4 interop#553

Merged
Ralith merged 1 commit intomasterfrom
raw-window-handle-0.3-0.4
Jan 10, 2022
Merged

ash-window: Require at least raw-window-handle 0.3.4 for 0.4 interop#553
Ralith merged 1 commit intomasterfrom
raw-window-handle-0.3-0.4

Conversation

@MarijnS95
Copy link
Copy Markdown
Collaborator

raw-window-handle 0.3.4 was pushed as a "semver-trick-like" patch release, implementing the 0.3 trait for the 0.4 crate release 74. This allows ash-window as a window-handle "consumer" crate to accept both 0.3 and i0.4 handles from consumer crates simultaneously. To ensure this patch release is available even when users omit regular cargo update or build with -Z minimal-versions, set the minimal patch version in Cargo.toml to it.

CC @dvc94ch, #505 (comment)

`raw-window-handle 0.3.4` was pushed as a "semver-trick-like" patch
release, implementing the `0.3` trait for the `0.4` crate release [74].
This allows `ash-window` as a window-handle "consumer" crate to accept
both `0.3` and `0.4` handles from consumer crates simultaneously.  To
ensure this patch release is available even when users omit regular
`cargo update` or build with `-Z minimal-versions`, set the minimal
patch version in `Cargo.toml` to it.

[74]: rust-windowing/raw-window-handle#74
Copy link
Copy Markdown
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@Ralith Ralith merged commit 130c150 into master Jan 10, 2022
@Ralith Ralith deleted the raw-window-handle-0.3-0.4 branch January 10, 2022 20:59
MarijnS95 added a commit that referenced this pull request Jan 11, 2022


And drop the deprecated =/- markdown syntax from our readme: this is
analogous to #/## for a h1/h2 header, instead of defining a title and
(usually smaller font) subtitle or description.
MarijnS95 added a commit that referenced this pull request Jan 17, 2022


And drop the deprecated =/- markdown syntax from our readme: this is
analogous to #/## for a h1/h2 header, instead of defining a title and
(usually smaller font) subtitle or description.
MarijnS95 added a commit that referenced this pull request Jan 17, 2022


And drop the deprecated =/- markdown syntax from our readme: this is
analogous to #/## for a h1/h2 header, instead of defining a title and
(usually smaller font) subtitle or description.
MarijnS95 added a commit that referenced this pull request Jan 17, 2022
)

And drop the deprecated =/- markdown syntax from our readme: this is
analogous to #/## for a h1/h2 header, instead of defining a title and
(usually smaller font) subtitle or description.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants