Skip to content

Update raw-window-handle to 0.4.1#1957

Merged
msiglreith merged 2 commits intorust-windowing:masterfrom
madsmtm:update-raw-window-handle
Nov 30, 2021
Merged

Update raw-window-handle to 0.4.1#1957
msiglreith merged 2 commits intorust-windowing:masterfrom
madsmtm:update-raw-window-handle

Conversation

@madsmtm
Copy link
Copy Markdown
Member

@madsmtm madsmtm commented Jun 5, 2021 •
edited
Loading

Ready for when rust-windowing/raw-window-handle#70 gets merged, and a stable version published.

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

msiglreith
msiglreith reviewed Jun 5, 2021
View reviewed changes
@madsmtm madsmtm force-pushed the update-raw-window-handle branch from deba6fd to adc7a2b Compare November 19, 2021 09:21
@madsmtm madsmtm changed the title Update raw-window-handle to 0.4.0 Update raw-window-handle to 0.4.1 Nov 19, 2021
@madsmtm madsmtm marked this pull request as ready for review November 19, 2021 09:25
@madsmtm
Copy link
Copy Markdown
Member Author

madsmtm commented Nov 19, 2021

This should be ready now, but I don't think it should be included in the 0.26.0 release, since that will prevent winit 0.26.0 from being used with crates that are using raw-window-handle version 0.3. We probably need to do collaborate on an ecosystem-wide rollout

@madsmtm
Copy link
Copy Markdown
Member Author

madsmtm commented Nov 19, 2021

See rust-windowing/raw-window-handle#74 for an upgrade plan

@maroider maroider mentioned this pull request Nov 20, 2021
Merged
9 tasks
@Gordon-F Gordon-F mentioned this pull request Nov 23, 2021
Merged
@kchibisov
Copy link
Copy Markdown
Member

kchibisov commented Nov 24, 2021

@madsmtm Could you provide an update on this PR? I can't keep an eye on all the bits in ecosystem right now, and I don't want to hold v0.26.0 release of winit.

@madsmtm
Copy link
Copy Markdown
Member Author

madsmtm commented Nov 24, 2021

This is currently waiting on raw-window-handle v0.3.4 being released, I suspect it will take a day, maybe three. See rust-windowing/raw-window-handle#79.

If it takes longer due to unforeseen circumstances, I'm fine with just releasing winit v0.26.0 as-is.

@a1phyr
Copy link
Copy Markdown
Contributor

a1phyr commented Nov 27, 2021

raw-window-handle v0.3.4 has just been released, so this can go forward.

@madsmtm madsmtm force-pushed the update-raw-window-handle branch 2 times, most recently from 6916a99 to 38bab38 Compare November 27, 2021 10:16
@madsmtm madsmtm force-pushed the update-raw-window-handle branch from 38bab38 to 729e0c6 Compare November 27, 2021 10:18
@madsmtm
Copy link
Copy Markdown
Member Author

madsmtm commented Nov 27, 2021

Yup, this is ready to be merged.

I've tested this with a small personal project using bevy, they use the raw-window-handle traits from v0.3, and it works fine with this PR.

Again, just for clarification, because of the blanket impl<T: new::HasRawWindowHandle> old::HasRawWindowHandle for T in v0.3.4, by implementing the new trait we still implement the old one. Hence this is not a breaking change! (Users might have to do a cargo update though, not entirely sure about how the cargo caching works).

msiglreith
msiglreith reviewed Nov 27, 2021
View reviewed changes
@madsmtm madsmtm force-pushed the update-raw-window-handle branch from 729e0c6 to 5176dd6 Compare November 28, 2021 09:52
@msiglreith msiglreith merged commit 5eb9c95 into rust-windowing:master Nov 30, 2021
@madsmtm madsmtm deleted the update-raw-window-handle branch December 1, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@msiglreith msiglreith msiglreith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@madsmtm @kchibisov @a1phyr @msiglreith