Rename `errors.rs` file to `diagnostics.rs` (6/N) by GuillaumeGomez · Pull Request #157752 · rust-lang/rust

GuillaumeGomez · 2026-06-11T10:09:42Z

Follow-up of #157485.

r? @JonathanBrouwer

rustbot · 2026-06-11T10:09:47Z

HIR ty lowering was modified

cc @fmease

JonathanBrouwer

@bors r+ rollup

View changes since this review

rust-bors · 2026-06-11T10:14:56Z

📌 Commit f1c371f has been approved by JonathanBrouwer

It is now in the queue for this repository.

GuillaumeGomez · 2026-06-12T10:45:55Z

@bors r=JonathanBrouwer rollup

rust-bors · 2026-06-12T10:45:57Z

📌 Commit 14bce1a has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…3, r=JonathanBrouwer Rename `errors.rs` file to `diagnostics.rs` (6/N) Follow-up of rust-lang#157485. r? @JonathanBrouwer

@JonathanBrouwer

…3, r=JonathanBrouwer Rename `errors.rs` file to `diagnostics.rs` (6/N) Follow-up of rust-lang#157485. r? @JonathanBrouwer

@JonathanBrouwer

…3, r=JonathanBrouwer Rename `errors.rs` file to `diagnostics.rs` (6/N) Follow-up of rust-lang#157485. r? @JonathanBrouwer

…uwer Rollup of 17 pull requests Successful merges: - #156950 (Staticlib rename internal symbols) - #157322 (test pre-stabilization items on CI) - #157490 (Add field-wise CoerceShared reborrow tests) - #157655 (Make Share::share final and improve docs) - #157688 (Create experimental test job `aarch64-apple-macos-26` for evaluating `macos-26` runner images) - #157796 (rustdoc: Some more lazy formatting) - #157069 (Test that you can't implement Unpin for a compiler-generated future using TAIT) - #157202 (add #[rustc_no_writable] to slice::get_unchecked_mut) - #157622 (Disable retagging for variadic arguments in const-eval) - #157684 (-Zassumptions-on-binders: insert empty assumptions when entering binders in the solver) - #157695 (Extend capabilities of `TypeFoldable_Generic`) - #157752 (Rename `errors.rs` file to `diagnostics.rs` (6/N)) - #157766 (interpret: avoid computing layout of sized raw pointee) - #157785 (fuchsia: Support AddressSanitizer on riscv64gc-unknown-fuchsia) - #157795 (revert 157013) - #157798 (Prevent approving PRs that wait for Crater or formal decisions) - #157803 (Rename `errors.rs` file to `diagnostics.rs` (7/N))

@JonathanBrouwer

…3, r=JonathanBrouwer Rename `errors.rs` file to `diagnostics.rs` (6/N) Follow-up of rust-lang#157485. r? @JonathanBrouwer

…uwer Rollup of 23 pull requests Successful merges: - #144220 (Add powerpc64-unknown-linux-gnuelfv2 target) - #153238 (debuginfo: slices are DW_TAG_array_type's) - #157112 (Update aarch64-unknown-freebsd target description) - #157322 (test pre-stabilization items on CI) - #157348 (Don't track cwd for `-Zremap-cwd-prefix` in incremental compilation) - #157490 (Add field-wise CoerceShared reborrow tests) - #157655 (Make Share::share final and improve docs) - #157672 (Region inference: Simplify initialisation of region values) - #157680 (Require `#[pin_v2]` for explicit pin-projection patterns) - #157688 (Create experimental test job `aarch64-apple-macos-26` for evaluating `macos-26` runner images) - #157796 (rustdoc: Some more lazy formatting) - #157818 (miri subtree update) - #157069 (Test that you can't implement Unpin for a compiler-generated future using TAIT) - #157079 (Don't recover `&raw EXPR` as a missing comma) - #157202 (add #[rustc_no_writable] to slice::get_unchecked_mut) - #157622 (Disable retagging for variadic arguments in const-eval) - #157684 (-Zassumptions-on-binders: insert empty assumptions when entering binders in the solver) - #157695 (Extend capabilities of `TypeFoldable_Generic`) - #157766 (interpret: avoid computing layout of sized raw pointee) - #157785 (fuchsia: Support AddressSanitizer on riscv64gc-unknown-fuchsia) - #157795 (revert 157013) - #157798 (Prevent approving PRs that wait for Crater or formal decisions) - #157803 (Rename `errors.rs` file to `diagnostics.rs` (7/N)) Failed merges: - #157752 (Rename `errors.rs` file to `diagnostics.rs` (6/N))

…uwer Rollup of 23 pull requests Successful merges: - rust-lang/rust#144220 (Add powerpc64-unknown-linux-gnuelfv2 target) - rust-lang/rust#153238 (debuginfo: slices are DW_TAG_array_type's) - rust-lang/rust#157112 (Update aarch64-unknown-freebsd target description) - rust-lang/rust#157322 (test pre-stabilization items on CI) - rust-lang/rust#157348 (Don't track cwd for `-Zremap-cwd-prefix` in incremental compilation) - rust-lang/rust#157490 (Add field-wise CoerceShared reborrow tests) - rust-lang/rust#157655 (Make Share::share final and improve docs) - rust-lang/rust#157672 (Region inference: Simplify initialisation of region values) - rust-lang/rust#157680 (Require `#[pin_v2]` for explicit pin-projection patterns) - rust-lang/rust#157688 (Create experimental test job `aarch64-apple-macos-26` for evaluating `macos-26` runner images) - rust-lang/rust#157796 (rustdoc: Some more lazy formatting) - rust-lang/rust#157818 (miri subtree update) - rust-lang/rust#157069 (Test that you can't implement Unpin for a compiler-generated future using TAIT) - rust-lang/rust#157079 (Don't recover `&raw EXPR` as a missing comma) - rust-lang/rust#157202 (add #[rustc_no_writable] to slice::get_unchecked_mut) - rust-lang/rust#157622 (Disable retagging for variadic arguments in const-eval) - rust-lang/rust#157684 (-Zassumptions-on-binders: insert empty assumptions when entering binders in the solver) - rust-lang/rust#157695 (Extend capabilities of `TypeFoldable_Generic`) - rust-lang/rust#157766 (interpret: avoid computing layout of sized raw pointee) - rust-lang/rust#157785 (fuchsia: Support AddressSanitizer on riscv64gc-unknown-fuchsia) - rust-lang/rust#157795 (revert 157013) - rust-lang/rust#157798 (Prevent approving PRs that wait for Crater or formal decisions) - rust-lang/rust#157803 (Rename `errors.rs` file to `diagnostics.rs` (7/N)) Failed merges: - rust-lang/rust#157752 (Rename `errors.rs` file to `diagnostics.rs` (6/N))

…c/diagnostics.rs`

rustbot · 2026-06-13T12:36:45Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

…agnostics.rs`

GuillaumeGomez · 2026-06-13T12:56:34Z

@bors r=JonathanBrouwer rollup

rust-bors · 2026-06-13T12:56:37Z

📌 Commit 190a22d has been approved by JonathanBrouwer

It is now in the queue for this repository.

rust-log-analyzer · 2026-06-13T13:57:53Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

...............................F.................. (50/144)
.................................................. (100/144)
............................................       (144/144)

======== tests/rustdoc-gui/go-to-collapsed-elem.goml ========

[ERROR] line 40
    at `tests/rustdoc-gui/go-to-collapsed-elem.goml` line 21: Error: Node is detached from document: for command `click: "//*[@id='search']//a[@href='../test_docs/struct.Foo.html#method.must_use']"`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.Foo.html?search=t_use>


<= doc-ui tests done: 143 succeeded, 1 failed, 0 filtered out

Error: ()

…uwer Rollup of 5 pull requests Successful merges: - #157518 (Add xdg_basedir API) - #157752 (Rename `errors.rs` file to `diagnostics.rs` (6/N)) - #157769 (Match expressions had not been updated to also show the match_source,…) - #157825 (Emit retags in codegen to support BorrowSanitizer (part 3)) - #157861 (Rename `errors.rs` file to `diagnostics.rs` (7/N))

@JonathanBrouwer

Rollup merge of #157752 - GuillaumeGomez:rename-err-to-diag-3, r=JonathanBrouwer Rename `errors.rs` file to `diagnostics.rs` (6/N) Follow-up of #157485. r? @JonathanBrouwer

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 11, 2026

rustbot assigned JonathanBrouwer Jun 11, 2026

JonathanBrouwer changed the title ~~Rename errors.rs file to diagnostics.rs (5/N)~~ Rename errors.rs file to diagnostics.rs (6/N) Jun 11, 2026

JonathanBrouwer approved these changes Jun 11, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

GuillaumeGomez force-pushed the rename-err-to-diag-3 branch from f1c371f to 14bce1a Compare June 12, 2026 10:22

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 12, 2026

GuillaumeGomez mentioned this pull request Jun 12, 2026

Rollup of 9 pull requests #157804

Closed

JonathanBrouwer mentioned this pull request Jun 12, 2026

Rollup of 14 pull requests #157809

Closed

JonathanBrouwer mentioned this pull request Jun 12, 2026

Rollup of 17 pull requests #157815

Closed

This was referenced Jun 12, 2026

Rollup of 23 pull requests #157827

Closed

Rollup of 23 pull requests #157828

Merged

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 12, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 12, 2026

Rename rustc_hir_analysis/src/errors.rs into `rustc_hir_analysis/sr…

f6e99c1

…c/diagnostics.rs`

GuillaumeGomez force-pushed the rename-err-to-diag-3 branch from 14bce1a to 7ce793b Compare June 13, 2026 12:36

This comment has been minimized.

Sign in to view

Rename rustc_hir_typeck/src/errors.rs into `rustc_hir_typeck/src/di…

190a22d

…agnostics.rs`

GuillaumeGomez force-pushed the rename-err-to-diag-3 branch from 7ce793b to 190a22d Compare June 13, 2026 12:56

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 13, 2026

JonathanBrouwer mentioned this pull request Jun 13, 2026

Rollup of 5 pull requests #157863

Merged

rust-bors Bot merged commit 04724ff into rust-lang:main Jun 13, 2026
9 of 13 checks passed

rustbot added this to the 1.98.0 milestone Jun 13, 2026

rust-timer added a commit that referenced this pull request Jun 13, 2026

Unrolled build for #157752

5155e95

Rollup merge of #157752 - GuillaumeGomez:rename-err-to-diag-3, r=JonathanBrouwer Rename `errors.rs` file to `diagnostics.rs` (6/N) Follow-up of #157485. r? @JonathanBrouwer

GuillaumeGomez deleted the rename-err-to-diag-3 branch June 13, 2026 18:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rename `errors.rs` file to `diagnostics.rs` (6/N)#157752

Rename `errors.rs` file to `diagnostics.rs` (6/N)#157752
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
GuillaumeGomez:rename-err-to-diag-3

GuillaumeGomez commented Jun 11, 2026

Uh oh!

rustbot commented Jun 11, 2026

Uh oh!

JonathanBrouwer left a comment •

edited by rustbot

Loading

Uh oh!

rust-bors Bot commented Jun 11, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

GuillaumeGomez commented Jun 12, 2026

Uh oh!

rust-bors Bot commented Jun 12, 2026

Uh oh!

This comment has been minimized.

rustbot commented Jun 13, 2026

Uh oh!

This comment has been minimized.

GuillaumeGomez commented Jun 13, 2026

Uh oh!

rust-bors Bot commented Jun 13, 2026

Uh oh!

rust-log-analyzer commented Jun 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

GuillaumeGomez commented Jun 11, 2026

Uh oh!

rustbot commented Jun 11, 2026

Uh oh!

JonathanBrouwer left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Jun 11, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

GuillaumeGomez commented Jun 12, 2026

Uh oh!

rust-bors Bot commented Jun 12, 2026

Uh oh!

This comment has been minimized.

rustbot commented Jun 13, 2026

Uh oh!

This comment has been minimized.

GuillaumeGomez commented Jun 13, 2026

Uh oh!

rust-bors Bot commented Jun 13, 2026

Uh oh!

rust-log-analyzer commented Jun 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JonathanBrouwer left a comment •

edited by rustbot

Loading