rustdoc: Some more lazy formatting by yotamofek · Pull Request #157796 · rust-lang/rust

yotamofek · 2026-06-12T07:10:09Z

Mostly replaces format! calls with format_args!

rustbot · 2026-06-12T07:10:18Z

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: rustdoc
rustdoc expanded to 9 candidates
Random selection from GuillaumeGomez, camelid, notriddle

Mostly replaces a few `format!` calls with `format_args!`

Kobzol · 2026-06-12T08:33:32Z

@bors try @rust-timer queue

…<try> rustdoc: Some more lazy formatting

GuillaumeGomez · 2026-06-12T10:02:37Z

Changes look good to me. Let's see what perf says.

rust-bors · 2026-06-12T10:45:44Z

☀️ Try build successful (CI)
Build commit: 292a5f7 (292a5f7d9943858f6868c4b613c63856e24e9165, parent: 09a371361240e42b0d69438fd1179efcf212e576)

rust-timer · 2026-06-12T12:05:58Z

Finished benchmarking commit (292a5f7): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (secondary -2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.7%, -2.7%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 517.481s -> 517.65s (0.03%)
Artifact size: 401.31 MiB -> 400.81 MiB (-0.12%)

GuillaumeGomez · 2026-06-12T12:54:03Z

Nice! Well done. :)

@bors r+

rust-bors · 2026-06-12T12:54:07Z

📌 Commit e04bcaf has been approved by GuillaumeGomez

It is now in the queue for this repository.

…matting, r=GuillaumeGomez rustdoc: Some more lazy formatting Mostly replaces `format!` calls with `format_args!`

…uwer Rollup of 17 pull requests Successful merges: - #156950 (Staticlib rename internal symbols) - #157322 (test pre-stabilization items on CI) - #157490 (Add field-wise CoerceShared reborrow tests) - #157655 (Make Share::share final and improve docs) - #157688 (Create experimental test job `aarch64-apple-macos-26` for evaluating `macos-26` runner images) - #157796 (rustdoc: Some more lazy formatting) - #157069 (Test that you can't implement Unpin for a compiler-generated future using TAIT) - #157202 (add #[rustc_no_writable] to slice::get_unchecked_mut) - #157622 (Disable retagging for variadic arguments in const-eval) - #157684 (-Zassumptions-on-binders: insert empty assumptions when entering binders in the solver) - #157695 (Extend capabilities of `TypeFoldable_Generic`) - #157752 (Rename `errors.rs` file to `diagnostics.rs` (6/N)) - #157766 (interpret: avoid computing layout of sized raw pointee) - #157785 (fuchsia: Support AddressSanitizer on riscv64gc-unknown-fuchsia) - #157795 (revert 157013) - #157798 (Prevent approving PRs that wait for Crater or formal decisions) - #157803 (Rename `errors.rs` file to `diagnostics.rs` (7/N))

…matting, r=GuillaumeGomez rustdoc: Some more lazy formatting Mostly replaces `format!` calls with `format_args!`

…uwer Rollup of 23 pull requests Successful merges: - #144220 (Add powerpc64-unknown-linux-gnuelfv2 target) - #153238 (debuginfo: slices are DW_TAG_array_type's) - #157112 (Update aarch64-unknown-freebsd target description) - #157322 (test pre-stabilization items on CI) - #157348 (Don't track cwd for `-Zremap-cwd-prefix` in incremental compilation) - #157490 (Add field-wise CoerceShared reborrow tests) - #157655 (Make Share::share final and improve docs) - #157672 (Region inference: Simplify initialisation of region values) - #157680 (Require `#[pin_v2]` for explicit pin-projection patterns) - #157688 (Create experimental test job `aarch64-apple-macos-26` for evaluating `macos-26` runner images) - #157796 (rustdoc: Some more lazy formatting) - #157818 (miri subtree update) - #157069 (Test that you can't implement Unpin for a compiler-generated future using TAIT) - #157079 (Don't recover `&raw EXPR` as a missing comma) - #157202 (add #[rustc_no_writable] to slice::get_unchecked_mut) - #157622 (Disable retagging for variadic arguments in const-eval) - #157684 (-Zassumptions-on-binders: insert empty assumptions when entering binders in the solver) - #157695 (Extend capabilities of `TypeFoldable_Generic`) - #157766 (interpret: avoid computing layout of sized raw pointee) - #157785 (fuchsia: Support AddressSanitizer on riscv64gc-unknown-fuchsia) - #157795 (revert 157013) - #157798 (Prevent approving PRs that wait for Crater or formal decisions) - #157803 (Rename `errors.rs` file to `diagnostics.rs` (7/N)) Failed merges: - #157752 (Rename `errors.rs` file to `diagnostics.rs` (6/N))

Rollup merge of #157796 - yotamofek:pr/rustdoc/more-lazy-formatting, r=GuillaumeGomez rustdoc: Some more lazy formatting Mostly replaces `format!` calls with `format_args!`

…uwer Rollup of 23 pull requests Successful merges: - rust-lang/rust#144220 (Add powerpc64-unknown-linux-gnuelfv2 target) - rust-lang/rust#153238 (debuginfo: slices are DW_TAG_array_type's) - rust-lang/rust#157112 (Update aarch64-unknown-freebsd target description) - rust-lang/rust#157322 (test pre-stabilization items on CI) - rust-lang/rust#157348 (Don't track cwd for `-Zremap-cwd-prefix` in incremental compilation) - rust-lang/rust#157490 (Add field-wise CoerceShared reborrow tests) - rust-lang/rust#157655 (Make Share::share final and improve docs) - rust-lang/rust#157672 (Region inference: Simplify initialisation of region values) - rust-lang/rust#157680 (Require `#[pin_v2]` for explicit pin-projection patterns) - rust-lang/rust#157688 (Create experimental test job `aarch64-apple-macos-26` for evaluating `macos-26` runner images) - rust-lang/rust#157796 (rustdoc: Some more lazy formatting) - rust-lang/rust#157818 (miri subtree update) - rust-lang/rust#157069 (Test that you can't implement Unpin for a compiler-generated future using TAIT) - rust-lang/rust#157079 (Don't recover `&raw EXPR` as a missing comma) - rust-lang/rust#157202 (add #[rustc_no_writable] to slice::get_unchecked_mut) - rust-lang/rust#157622 (Disable retagging for variadic arguments in const-eval) - rust-lang/rust#157684 (-Zassumptions-on-binders: insert empty assumptions when entering binders in the solver) - rust-lang/rust#157695 (Extend capabilities of `TypeFoldable_Generic`) - rust-lang/rust#157766 (interpret: avoid computing layout of sized raw pointee) - rust-lang/rust#157785 (fuchsia: Support AddressSanitizer on riscv64gc-unknown-fuchsia) - rust-lang/rust#157795 (revert 157013) - rust-lang/rust#157798 (Prevent approving PRs that wait for Crater or formal decisions) - rust-lang/rust#157803 (Rename `errors.rs` file to `diagnostics.rs` (7/N)) Failed merges: - rust-lang/rust#157752 (Rename `errors.rs` file to `diagnostics.rs` (6/N))

rustbot assigned GuillaumeGomez Jun 12, 2026

rustdoc: Some more lazy formatting

e04bcaf

Mostly replaces a few `format!` calls with `format_args!`

yotamofek force-pushed the pr/rustdoc/more-lazy-formatting branch from ec07ed3 to e04bcaf Compare June 12, 2026 07:10

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 12, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jun 12, 2026

Auto merge of #157796 - yotamofek:pr/rustdoc/more-lazy-formatting, r=…

292a5f7

…<try> rustdoc: Some more lazy formatting

GuillaumeGomez approved these changes Jun 12, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 12, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2026

JonathanBrouwer mentioned this pull request Jun 12, 2026

Rollup of 17 pull requests #157815

Closed

This was referenced Jun 12, 2026

Rollup of 23 pull requests #157827

Closed

Rollup of 23 pull requests #157828

Merged

rust-bors Bot merged commit 0d01d51 into rust-lang:main Jun 12, 2026
13 checks passed

rustbot added this to the 1.98.0 milestone Jun 12, 2026

rust-timer added a commit that referenced this pull request Jun 12, 2026

Unrolled build for #157796

8286174

Rollup merge of #157796 - yotamofek:pr/rustdoc/more-lazy-formatting, r=GuillaumeGomez rustdoc: Some more lazy formatting Mostly replaces `format!` calls with `format_args!`

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

rustdoc: Some more lazy formatting#157796

rustdoc: Some more lazy formatting#157796
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
yotamofek:pr/rustdoc/more-lazy-formatting

yotamofek commented Jun 12, 2026

Uh oh!

rustbot commented Jun 12, 2026

Uh oh!

Kobzol commented Jun 12, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

GuillaumeGomez commented Jun 12, 2026

Uh oh!

rust-bors Bot commented Jun 12, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jun 12, 2026

Uh oh!

GuillaumeGomez commented Jun 12, 2026

Uh oh!

rust-bors Bot commented Jun 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

yotamofek commented Jun 12, 2026

Uh oh!

rustbot commented Jun 12, 2026

Uh oh!

Kobzol commented Jun 12, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

GuillaumeGomez commented Jun 12, 2026

Uh oh!

rust-bors Bot commented Jun 12, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jun 12, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

GuillaumeGomez commented Jun 12, 2026

Uh oh!

rust-bors Bot commented Jun 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants