Skip to content

Match expressions had not been updated to also show the match_source,…#157769

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
AlexCeleste:thir-missing-match-source
Jun 13, 2026
Merged

Match expressions had not been updated to also show the match_source,…#157769
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
AlexCeleste:thir-missing-match-source

Conversation

@AlexCeleste

Copy link
Copy Markdown
Contributor

… since the time that was added

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 11, 2026
@rustbot

rustbot commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 19 candidates

@rust-log-analyzer

This comment has been minimized.

@petrochenkov

Copy link
Copy Markdown
Contributor

r? @Nadrieril maybe, I'm not sure what this is about

@rustbot rustbot assigned Nadrieril and unassigned petrochenkov Jun 11, 2026
@rustbot

rustbot commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Nadrieril is currently at their maximum review capacity.
They may take a while to respond.

@AlexCeleste AlexCeleste force-pushed the thir-missing-match-source branch from 406d85a to ac251f4 Compare June 12, 2026 09:51
@rustbot

rustbot commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

This comment has been minimized.

@AlexCeleste AlexCeleste force-pushed the thir-missing-match-source branch from ac251f4 to 4da45bc Compare June 12, 2026 11:39
@rust-log-analyzer

This comment has been minimized.

@AlexCeleste AlexCeleste force-pushed the thir-missing-match-source branch from 4da45bc to 481db97 Compare June 12, 2026 12:27
@rust-log-analyzer

This comment has been minimized.

… since the time that was added

update existing match tests as well

remove hashes from output

remove specific DefIds for core from output

remove additional specifics that can vary and which are not relevant to the test
@AlexCeleste AlexCeleste force-pushed the thir-missing-match-source branch from 481db97 to d050769 Compare June 13, 2026 11:36
@AlexCeleste

Copy link
Copy Markdown
Contributor Author

@rustbot reroll

@rustbot rustbot assigned mu001999 and unassigned Nadrieril Jun 13, 2026
@AlexCeleste

Copy link
Copy Markdown
Contributor Author

apologies for those failures.

@Nadrieril

Copy link
Copy Markdown
Member

Oh yep, good catch!

r? me

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d050769 has been approved by Nadrieril

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2026
rust-bors Bot pushed a commit that referenced this pull request Jun 13, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #157518 (Add xdg_basedir API)
 - #157752 (Rename `errors.rs` file to `diagnostics.rs` (6/N))
 - #157769 (Match expressions had not been updated to also show the match_source,…)
 - #157825 (Emit retags in codegen to support BorrowSanitizer (part 3))
 - #157861 (Rename `errors.rs` file to `diagnostics.rs` (7/N))
@rust-bors rust-bors Bot merged commit f889de2 into rust-lang:main Jun 13, 2026
13 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jun 13, 2026
rust-timer added a commit that referenced this pull request Jun 13, 2026
Rollup merge of #157769 - AlexCeleste:thir-missing-match-source, r=Nadrieril

Match expressions had not been updated to also show the match_source,…

… since the time that was added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants