Skip to content

CI: Copy main workflow from master#3418

Merged
apoelstra merged 1 commit intorust-bitcoin:0.32.xfrom
tcharding:09-27-backport-ci
Oct 22, 2024
Merged

CI: Copy main workflow from master#3418
apoelstra merged 1 commit intorust-bitcoin:0.32.xfrom
tcharding:09-27-backport-ci

Conversation

@tcharding
Copy link
Copy Markdown
Member

@tcharding tcharding commented Sep 27, 2024

Copy the CI setup from master branch.

@tcharding tcharding force-pushed the 09-27-backport-ci branch 2 times, most recently from 121a811 to 386d393 Compare September 27, 2024 01:16
@github-actions github-actions bot added the C-hashes PRs modifying the hashes crate label Sep 27, 2024
@github-actions github-actions bot added C-bitcoin PRs modifying the bitcoin crate C-units PRs modifying the units crate C-base58 PRs modifying the base58 crate labels Sep 27, 2024
@github-actions github-actions bot added the C-internals PRs modifying the internals crate label Sep 27, 2024
@github-actions github-actions bot added the test label Sep 27, 2024
@tcharding
Copy link
Copy Markdown
Member Author

Converting to draft until I get motivate to debug.

Copy the `rust.yml` file from `master` at commit:

be4dffb Merge rust-bitcoin#3411: script: refactor
push_int_unchecked and test push_int overflow

Requires also copying:

- `contrib/crates.sh`
- `hashes/contrib/wasm.sh`
- `hashes/contrib/sanitizer.sh`
@tcharding tcharding marked this pull request as ready for review October 21, 2024 04:20
Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2a40a35; successfully ran local tests

@apoelstra apoelstra merged commit ab52e50 into rust-bitcoin:0.32.x Oct 22, 2024
@tcharding tcharding deleted the 09-27-backport-ci branch October 24, 2024 03:59
tcharding added a commit to tcharding/rust-bitcoin that referenced this pull request Nov 30, 2025
In commit 2a40a35 (PR rust-bitcoin#3418) I copied the `rust.yml` file from
`master` and in doing so used the wrong MSRV toolchain.

Use the correct MSRV toolchain for this branch.
apoelstra added a commit that referenced this pull request Dec 1, 2025
3e4c121 CI: Use correct MSRV toolchain (Tobin C. Harding)

Pull request description:

  In commit 2a40a35 (PR #3418) I copied the `rust.yml` file from `master` and in doing so used the wrong MSRV toolchain.
  
  Use the correct MSRV toolchain for this branch. This means that since October 2024 we have not been testing in CI with the advertised MSRV toolchain.
  
  Fix: #5350


ACKs for top commit:
  apoelstra:
    ACK 3e4c121; successfully ran local tests; since MSRV for this branch won't ever change, but really we ought to somehow get a SSOT here


Tree-SHA512: 0f0c839cf345016e75462406bac4f34461aae086d3c9757388dac0844340a60e608e26170084ba60de83e2b73388aa3ab9c99d8e647a7d4df56eb34b5e289a58
yancyribbens pushed a commit to yancyribbens/rust-bitcoin that referenced this pull request Dec 3, 2025
In commit 2a40a35 (PR rust-bitcoin#3418) I copied the `rust.yml` file from
`master` and in doing so used the wrong MSRV toolchain.

Use the correct MSRV toolchain for this branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-base58 PRs modifying the base58 crate C-bitcoin PRs modifying the bitcoin crate C-hashes PRs modifying the hashes crate C-internals PRs modifying the internals crate C-io PRs modifying the io crate C-units PRs modifying the units crate ci doc test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants