script: refactor push_int_unchecked and test push_int overflow#3411
Merged
apoelstra merged 2 commits intorust-bitcoin:masterfrom Sep 26, 2024
Merged
script: refactor push_int_unchecked and test push_int overflow#3411apoelstra merged 2 commits intorust-bitcoin:masterfrom
apoelstra merged 2 commits intorust-bitcoin:masterfrom
Conversation
Pull Request Test Coverage Report for Build 11043704970Details
💛 - Coveralls |
tcharding
approved these changes
Sep 26, 2024
Member
|
Thanks man! You're killing it these days. FYI we use a script to merge and it causes a load of notifications if there is a mention in the PR description. I removed the |
tcharding
added a commit
to tcharding/rust-bitcoin
that referenced
this pull request
Oct 15, 2024
Copy the `rust.yml` file from `master` at commit: be4dffb Merge rust-bitcoin#3411: script: refactor push_int_unchecked and test push_int overflow Requires also copying: - `contrib/crates.sh` - `hashes/contrib/wasm.sh` - `hashes/contrib/sanitizer.sh`
tcharding
added a commit
to tcharding/rust-bitcoin
that referenced
this pull request
Oct 21, 2024
Copy the `rust.yml` file from `master` at commit: be4dffb Merge rust-bitcoin#3411: script: refactor push_int_unchecked and test push_int overflow Requires also copying: - `contrib/crates.sh` - `hashes/contrib/wasm.sh` - `hashes/contrib/sanitizer.sh`
yancyribbens
pushed a commit
to yancyribbens/rust-bitcoin
that referenced
this pull request
Dec 3, 2025
Copy the `rust.yml` file from `master` at commit: be4dffb Merge rust-bitcoin#3411: script: refactor push_int_unchecked and test push_int overflow Requires also copying: - `contrib/crates.sh` - `hashes/contrib/wasm.sh` - `hashes/contrib/sanitizer.sh`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #3392
c9988ba
push_int_uncheckedwith match expression for cleaner code(many thanks for tcharding Follow up #3392 (refactor) #3407).a33bcd3
push_intfunction as expected, testing if returnsError::NumericOverflowwhennisi32::MIN