CI: Use correct MSRV toolchain#5351
Merged
apoelstra merged 1 commit intorust-bitcoin:0.32.xfrom Dec 1, 2025
Merged
Conversation
In commit 2a40a35 (PR rust-bitcoin#3418) I copied the `rust.yml` file from `master` and in doing so used the wrong MSRV toolchain. Use the correct MSRV toolchain for this branch.
Member
Author
|
@apoelstra has your CI setup been using the correct one? I.e are your scripts totally custom or do you somehow base them off of |
Member
Author
|
GitHub is not picking up that this PR closes an issue, second time I've seen that bug recently. EDIT: I raised a ticket: https://support.github.com/ticket/personal/0/3932091 |
Member
My stuff reads clippy.toml. |
Member
Author
|
Phew so we were covered all this time. Great. Thanks man. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In commit 2a40a35 (PR #3418) I copied the
rust.ymlfile frommasterand in doing so used the wrong MSRV toolchain.Use the correct MSRV toolchain for this branch. This means that since October 2024 we have not been testing in CI with the advertised MSRV toolchain.
Fix: #5350