[foxy] Export YAML_CPP_DLL define on Windows#30
Merged
jacobperron merged 1 commit intoros2:foxyfrom Feb 16, 2022
Merged
Conversation
Signed-off-by: Akash Munagala <akash.munagala@gmail.com>
jacobperron
approved these changes
Feb 15, 2022
Member
|
I was mistaken, the MSBuild warnings are related to this change. Hopefully, we can get the patches mentioned here #31 (comment) backported to Foxy. |
jacobperron
added a commit
that referenced
this pull request
Sep 12, 2022
This reverts commit efe5371.
Member
|
Reverting this change in #37 |
jacobperron
pushed a commit
that referenced
this pull request
Sep 20, 2022
Signed-off-by: Akash Munagala <akash.munagala@gmail.com>
jacobperron
pushed a commit
that referenced
this pull request
Sep 20, 2022
Signed-off-by: Akash Munagala <akash.munagala@gmail.com>
This was referenced Sep 20, 2022
jacobperron
added a commit
that referenced
this pull request
Oct 4, 2022
* Use target name directly instead of variable * Add comment explaining why we are setting YAML_CPP_DLL Co-authored-by: Akash <Ace314159@users.noreply.github.com> Signed-off-by: Akash Munagala <akash.munagala@gmail.com> Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10