[rolling] Export YAML_CPP_DLL define on Windows (#30)#38
Merged
jacobperron merged 3 commits intorollingfrom Oct 4, 2022
Merged
[rolling] Export YAML_CPP_DLL define on Windows (#30)#38jacobperron merged 3 commits intorollingfrom
jacobperron merged 3 commits intorollingfrom
Conversation
Signed-off-by: Akash Munagala <akash.munagala@gmail.com>
Member
Author
|
Requires the following changes to avoid build warnings: |
Member
Author
|
CI with connected PRs:
|
clalancette
approved these changes
Sep 21, 2022
Contributor
There was a problem hiding this comment.
I've left a suggestion for a comment, just to capture some of the investigation we did yesterday. I'm still approving since it is just a comment. No need to rerun CI with this change; a clean Rpr job is enough (and green CI on Windows, obviously).
Ace314159
reviewed
Sep 27, 2022
Signed-off-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Akash <Ace314159@users.noreply.github.com>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
Author
|
Windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward port #30 to Rolling.
This should fix #10