Skip to content

[Windows] It is nice YAML_CPP_DLL is exported by default. #10

@seanyen

Description

@seanyen

On Windows, the yaml-cpp is built as shared libraries. In such case, YAML_CPP_DLL is required to define to correctly consume the yaml-cpp (otherwise, visibility decoration won't be defined and it results in linkage time error).

And currently every project consuming yaml-cpp will need to define it in their CMake project to enable Windows build. It would be nice to see this exported directly from this package and all the downstream project can get the definition for free.

UPDATED:
For example,

And I discovered this issue when I try to enable navigation2 on Windows.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions