info message comes from deferred signal handler with another thread.#576
info message comes from deferred signal handler with another thread.#576
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates expected test outputs to reflect a change in message ordering caused by moving the signal handler info message from the system-managed signal handler to a deferred signal handler managed by rclcpp in another thread. The rclcpp signal handler message now appears after the custom signal handler message instead of before it.
- Updates expected output files for signal handler tests to match new message ordering
- Moves the
[INFO] [rclcpp]: signal_handler(signum=X)message from line 3 to line 5 in both test output files
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test_sigterm_handler_before_shutdown__expected_output.txt | Updates expected output to show rclcpp signal handler message appearing after custom SIGTERM handler message |
| test_sigint_handler_before_shutdown__expected_output.txt | Updates expected output to show rclcpp signal handler message appearing after custom SIGINT handler message |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [INFO] [rclcpp]: signal_handler(signum=2) | ||
| [INFO] [test_signal_handler]: Custom sigint handler called. | ||
| [INFO] [rclcpp]: signal_handler(signum=2) |
There was a problem hiding this comment.
now user's signal handler message should come before deferred signal hander message.
|
Pulls: ros2/rclcpp#2986, #576
|
|
|
@Mergifyio backport kilted jazzy humble |
✅ Backports have been createdDetails
|
Description
ros2/rclcpp#2986 moves the info message print from actual signal hander managed by system to deferred signal handler managed by rclcpp. this changes the order of expected message for these tests.
Depends on ros2/rclcpp#2986
Is this user-facing behavior change?
No,
Did you use Generative AI?
No,
Additional Information
If this does not work, we probably change the message from deferred signal hander into DEBUG because it is hard to guarantee the order of the messages between application main thread and deferred signal thread.