Skip to content

info message comes from deferred signal handler with another thread. (backport #576)#577

Closed
mergify[bot] wants to merge 1 commit intokiltedfrom
mergify/bp/kilted/pr-576
Closed

info message comes from deferred signal handler with another thread. (backport #576)#577
mergify[bot] wants to merge 1 commit intokiltedfrom
mergify/bp/kilted/pr-576

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify bot commented Nov 21, 2025

Description

ros2/rclcpp#2986 moves the info message print from actual signal hander managed by system to deferred signal handler managed by rclcpp. this changes the order of expected message for these tests.

Depends on ros2/rclcpp#2986

Is this user-facing behavior change?

No,

Did you use Generative AI?

No,

Additional Information

If this does not work, we probably change the message from deferred signal hander into DEBUG because it is hard to guarantee the order of the messages between application main thread and deferred signal thread.


This is an automatic backport of pull request #576 done by [Mergify](https://mergify.com).

…576)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 7b27452)
@fujitatomoya
Copy link
Copy Markdown
Contributor

Pulls: ros2/rclcpp#2995, #577
Gist: https://gist.githubusercontent.com/fujitatomoya/1a3250e73075c2377ce164d91d221cef/raw/2de334166f0763af83c04a8b426de0c3dd356208/ros2.repos
BUILD args: --packages-above-and-dependencies ‎rclcll test_rclcpp
TEST args: --packages-above ‎rclcll test_rclcpp
ROS Distro: kilted
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17561

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Contributor

fujitatomoya commented Nov 21, 2025

Pulls: ros2/rclcpp#2995, #577
Gist: https://gist.githubusercontent.com/fujitatomoya/1a919e0b8d65564c60068e863de10e4a/raw/2de334166f0763af83c04a8b426de0c3dd356208/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp test_rclcpp
TEST args: --packages-above rclcpp test_rclcpp
ROS Distro: kilted
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17564

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Contributor

This is ABI breaking change, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant