add test with multiple service calls#57
Merged
dirk-thomas merged 1 commit intomasterfrom Oct 15, 2015
Merged
Conversation
Contributor
|
Nice. Just for my own sanity, I'm going to build and the |
Member
|
+1 |
Closed
Contributor
|
The test passed 50/50 times on my machine. I feel good about that. +1 |
Member
|
I've merged the two PRs that fix the issue, this PR should be ready for merging. |
dirk-thomas
added a commit
that referenced
this pull request
Oct 15, 2015
add test with multiple service calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new test implement exactly the same test for services as #20 does for pub/sub. It covers what has been tracked in ros2/rclcpp#52 for a while.
Without any patches the test fails since most rmw implementations currently don't wake up a second time: http://ci.ros2.org/job/ros2_batch_ci_osx/349/
With the two patches (ros2/rmw_connext#66 ros2/rmw_opensplice#60) the test passes since the rmw implementations check the read correctly (as suggested in ros2/rclcpp#52 (comment)): http://ci.ros2.org/job/ros2_batch_ci_osx/350/
Connect to ros2/rclcpp#52