Skip to content

add test_rclcpp package testing subscriptions and spinning for now#20

Merged
dirk-thomas merged 1 commit intomasterfrom
test_rclcpp_package
Jul 29, 2015
Merged

add test_rclcpp package testing subscriptions and spinning for now#20
dirk-thomas merged 1 commit intomasterfrom
test_rclcpp_package

Conversation

@dirk-thomas
Copy link
Copy Markdown
Member

The test currently fails with all rmw implementations.

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Jul 29, 2015
@dirk-thomas dirk-thomas self-assigned this Jul 29, 2015
@dirk-thomas dirk-thomas force-pushed the test_rclcpp_package branch from f59c625 to 1a8ebcc Compare July 29, 2015 18:20
@esteve
Copy link
Copy Markdown
Member

esteve commented Jul 29, 2015

+1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are these variables used?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nowhere. I removed them. Thanks.

@jacquelinekay
Copy link
Copy Markdown
Contributor

Perhaps the timeout tests from /pull/19 should be in this package rather than test_communication. I can revisit that PR to put the test in test_rclcpp after this one gets merged if you agree.

@dirk-thomas
Copy link
Copy Markdown
Member Author

@jacquelinekay I agree the test_rclcpp is the better location for testing parameters.

@dirk-thomas dirk-thomas force-pushed the test_rclcpp_package branch 2 times, most recently from 94f6c39 to 1ce4ea9 Compare July 29, 2015 21:51
@dirk-thomas dirk-thomas force-pushed the test_rclcpp_package branch from 1ce4ea9 to 5f042d5 Compare July 29, 2015 21:56
dirk-thomas added a commit that referenced this pull request Jul 29, 2015
add test_rclcpp package testing subscriptions and spinning for now
@dirk-thomas dirk-thomas merged commit 2bcc233 into master Jul 29, 2015
@dirk-thomas dirk-thomas deleted the test_rclcpp_package branch July 29, 2015 21:56
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants