This repository was archived by the owner on Oct 7, 2021. It is now read-only.
Added read_condition for services and clients#60
Merged
Conversation
Member
Author
|
Linux buildfarm: |
Member
There was a problem hiding this comment.
This needs to be cleaned up in the fail section.
Same below.
Member
There was a problem hiding this comment.
May be you haven't pushed the fix yet?
Member
Author
There was a problem hiding this comment.
Yes, I hadn't pushed it yet. I say "Fixed" when I commit it.
14fb75f to
ade5bea
Compare
Member
|
+1 |
ade5bea to
831d582
Compare
Member
Author
|
Buildfarm job: |
Member
|
Code changes look good. |
Contributor
|
+1 |
831d582 to
3668503
Compare
3668503 to
e5142c1
Compare
1b29216 to
0faf49d
Compare
Contributor
|
Rebased |
Contributor
|
+1 |
esteve
added a commit
that referenced
this pull request
Oct 15, 2015
Added read_condition for services and clients
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rclcpp#52