Skip to content

Add test for test_msgs/NestedMessage.action#330

Merged
sloretz merged 2 commits intomasterfrom
actions_with_msgs_in_same_package
Feb 25, 2019
Merged

Add test for test_msgs/NestedMessage.action#330
sloretz merged 2 commits intomasterfrom
actions_with_msgs_in_same_package

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Feb 13, 2019

connects to ros2/rosidl#348
CI at ros2/rosidl_typesupport#44
requires ros2/rcl_interfaces#62

This PR should be backported to crystal

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz added the in review Waiting for review (Kanban column) label Feb 13, 2019
@sloretz sloretz self-assigned this Feb 13, 2019
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@cottsay cottsay requested a review from jacobperron February 21, 2019 18:47
Copy link
Copy Markdown
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sloretz sloretz merged commit 705c7b3 into master Feb 25, 2019
@sloretz sloretz deleted the actions_with_msgs_in_same_package branch February 25, 2019 16:44
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Feb 25, 2019
sloretz added a commit that referenced this pull request Mar 7, 2019
* Add test for test_msgs/NestedMessage.action

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Fixes for cpplint and uncrustify

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
nuclearsandwich pushed a commit that referenced this pull request Mar 10, 2019
* Add test for test_msgs/NestedMessage.action

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Fixes for cpplint and uncrustify

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants