Skip to content

Add action with nested messages#62

Merged
sloretz merged 2 commits intomasterfrom
actions_with_msgs_in_same_package
Feb 25, 2019
Merged

Add action with nested messages#62
sloretz merged 2 commits intomasterfrom
actions_with_msgs_in_same_package

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Feb 13, 2019

connects to ros2/rosidl#348
CI at ros2/rosidl_typesupport#44

This PR should be backported to crystal if ros2/system_tests#330 is

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Copy link
Copy Markdown
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@sloretz sloretz merged commit fd350a1 into master Feb 25, 2019
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Feb 25, 2019
@sloretz sloretz deleted the actions_with_msgs_in_same_package branch February 25, 2019 16:45
sloretz added a commit that referenced this pull request Mar 7, 2019
* Add action with nested messages

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* All nested types in each section

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants