Merged
Conversation
f2bbeb6 to
cd3469b
Compare
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
cd3469b to
43944c9
Compare
Contributor
Author
|
CI up to
|
Contributor
Author
j-rivero
reviewed
Jan 24, 2022
| * This functions performs a deep copy, as opposed to the shallow copy that | ||
| * plain assignment yields. | ||
| * | ||
| * \param[out] input a pointer to a rosidl_runtime_c__String structure |
There was a problem hiding this comment.
Suggested change
| * \param[out] input a pointer to a rosidl_runtime_c__String structure | |
| * \param[in] input a pointer to a rosidl_runtime_c__String structure |
j-rivero
reviewed
Jan 24, 2022
j-rivero
reviewed
Jan 24, 2022
j-rivero
reviewed
Jan 24, 2022
rosidl_runtime_c/include/rosidl_runtime_c/u16string_functions.h
Outdated
Show resolved
Hide resolved
j-rivero
reviewed
Jan 24, 2022
j-rivero
reviewed
Jan 24, 2022
j-rivero
left a comment
There was a problem hiding this comment.
Some minor comments, otherwise looks good to me. Great work.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
j-rivero
approved these changes
Jan 25, 2022
nnmm
pushed a commit
to nnmm/rosidl
that referenced
this pull request
Mar 8, 2022
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
nnmm
pushed a commit
to nnmm/rosidl
that referenced
this pull request
Mar 8, 2022
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
added a commit
that referenced
this pull request
Apr 25, 2022
* Implement equality operator function for C messages. (#648) Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Implement copy function for C messages (#650) Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Replace rcutils_allocator with the system allocator Signed-off-by: Nikolai Morin <nnmmgit@gmail.com> * Set the output size unconditionally when copying sequences Signed-off-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
added a commit
that referenced
this pull request
Apr 25, 2022
* Implement equality operator function for C messages. (#648) Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Implement copy function for C messages (#650) Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Replace rcutils_allocator with the system allocator Signed-off-by: Nikolai Morin <nnmmgit@gmail.com> * Set the output size unconditionally when copying sequences Signed-off-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
87 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precisely what the title says. While C++ messages overload the assignment operator, plain assignment of C messages results in shallow copy of pointers which in turn leads to ownership issues (e.g. double free crashes) down the line. This patch amends this.
Depends on #648.