Skip to content

Galactic backport of #648 and #650#668

Merged
hidmic merged 4 commits intoros2:galacticfrom
nnmm:galactic_backport_648_and_650
Apr 25, 2022
Merged

Galactic backport of #648 and #650#668
hidmic merged 4 commits intoros2:galacticfrom
nnmm:galactic_backport_648_and_650

Conversation

@nnmm
Copy link
Copy Markdown
Contributor

@nnmm nnmm commented Mar 8, 2022

This is helpful for the ros2_rust project.

I also backported the equality functions, since without them there were merge conflicts.

hidmic and others added 3 commits March 8, 2022 21:49
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Nikolai Morin <nnmmgit@gmail.com>
@nnmm
Copy link
Copy Markdown
Contributor Author

nnmm commented Mar 8, 2022

@hidmic Could you review?

Signed-off-by: Nikolai Morin <nnmmgit@gmail.com>
Copy link
Copy Markdown
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Galactic CI up to rosidl_generator_c and rosidl_runtime_c:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@nnmm
Copy link
Copy Markdown
Contributor Author

nnmm commented Apr 22, 2022

@hidmic Thank you for approving! Unfortunately I don't have write permissions, could you also merge this (and #667)?

@hidmic hidmic merged commit e9eea15 into ros2:galactic Apr 25, 2022
@nnmm
Copy link
Copy Markdown
Contributor Author

nnmm commented Apr 25, 2022

Thx! 🙏

@nnmm nnmm deleted the galactic_backport_648_and_650 branch April 25, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants