Export pluginlib to downstream packages#113
Merged
Karsten1987 merged 1 commit intoros2:masterfrom Jul 8, 2019
Merged
Conversation
kurcha01-arm
approved these changes
Jun 14, 2019
kurcha01-arm
left a comment
There was a problem hiding this comment.
Needed to pass cross-compilation on my machine
Collaborator
|
Sorry, I should have run CI on this way earlier:
|
Karsten1987
approved these changes
Jun 26, 2019
Collaborator
Karsten1987
left a comment
There was a problem hiding this comment.
looks good to me (with green CI)
Member
Author
|
@Karsten1987 no worries, thanks! |
Collaborator
|
I believe this has to be rebased to reflect the renaming changes of the test msgs package. |
Signed-off-by: Esteve Fernandez <esteve@apache.org>
Member
Author
|
@Karsten1987 I just rebased this PR, but I haven't had time to test it locally. |
Collaborator
|
new round of CI:
|
Member
Author
|
@Karsten1987 is there anything missing here that should be addressed before it's merged? |
Collaborator
|
Thanks @esteve for the patch. Sorry, I am pretty packed these days and not really super reactive on my github issues. |
Member
Author
|
@Karsten1987 no worries, thanks for merging the PR. |
hidmic
pushed a commit
that referenced
this pull request
Jul 26, 2019
Signed-off-by: Esteve Fernandez <esteve@apache.org>
hidmic
added a commit
that referenced
this pull request
Jul 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure if pluginlib should be exported, but with this change and ros/pluginlib#154 I was able to crosscompile rosbag2 for aarch64.