Skip to content

[Backport] Export pluginlib to downstream packages (#113)#144

Merged
hidmic merged 1 commit intodashingfrom
dashing_backport_113
Jul 29, 2019
Merged

[Backport] Export pluginlib to downstream packages (#113)#144
hidmic merged 1 commit intodashingfrom
dashing_backport_113

Conversation

@hidmic
Copy link
Copy Markdown

@hidmic hidmic commented Jul 26, 2019

Signed-off-by: Esteve Fernandez esteve@apache.org

Signed-off-by: Esteve Fernandez <esteve@apache.org>
@hidmic
Copy link
Copy Markdown
Author

hidmic commented Jul 26, 2019

Running CI up to rosbag2 against dashing:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic
Copy link
Copy Markdown
Author

hidmic commented Jul 29, 2019

@nuclearsandwich this PR went through the PR job plus a CI against dashing. Do you think we should run another CI against dashing-release or can we let this one in already?

@nuclearsandwich
Copy link
Copy Markdown
Member

Do you think we should run another CI against dashing-release or can we let this one in already?

I think it's fine to go ahead. At this point the dashing branch better reflects the upcoming patch 2 release than dashing-release does.

@hidmic hidmic merged commit 32612a0 into dashing Jul 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the dashing_backport_113 branch July 29, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants