Skip to content

Export tinyxml2 libraries downstream#154

Merged
nuclearsandwich merged 1 commit intoros:ros2from
esteve:export-tinyxml2
Jul 15, 2019
Merged

Export tinyxml2 libraries downstream#154
nuclearsandwich merged 1 commit intoros:ros2from
esteve:export-tinyxml2

Conversation

@esteve
Copy link
Copy Markdown
Member

@esteve esteve commented May 7, 2019

This change makes the tinxyml2 libraries available to downstream packages when they are crosscompiled. The calls to find_package are in the extras file because the tinyxml2 libraries may be installed system-wide and therefore have absolute paths, which can't be resolved when crosscompiling.

@nuclearsandwich nuclearsandwich self-requested a review May 7, 2019 12:03
@esteve esteve mentioned this pull request May 7, 2019
Merged
@Karsten1987
Copy link
Copy Markdown
Contributor

Karsten1987 commented May 28, 2019

@nuclearsandwich Are we considering this for Dashing?

@nuclearsandwich
Copy link
Copy Markdown
Member

nuclearsandwich commented May 28, 2019

If I had been more attentive to it it could likely have been included but I failed to take action earlier. I will add it to the first Dashing patch release queue.

@esteve esteve mentioned this pull request Jun 13, 2019
Closed
@esteve esteve mentioned this pull request Jun 26, 2019
Closed
@esteve
Copy link
Copy Markdown
Member Author

esteve commented Jul 11, 2019

@Karsten1987 @nuclearsandwich is there anything I should addressing in this PR? Thanks.

@nuclearsandwich
Copy link
Copy Markdown
Member

nuclearsandwich commented Jul 11, 2019

is there anything I should addressing in this PR? Thanks.

Nope I've just had a devil of a time clearing my review backlog.

I created an export-tinyxml2 branch on this fork and merged these changes into it for CI.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

nuclearsandwich
nuclearsandwich approved these changes Jul 11, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked a couple of clarifying questions but this should be good to merge as-is as long as there are no surprises during CI.

@nuclearsandwich nuclearsandwich merged commit bc325fb into ros:ros2 Jul 15, 2019
@esteve esteve deleted the export-tinyxml2 branch July 16, 2019 15:28
@esteve
Copy link
Copy Markdown
Member Author

esteve commented Jul 16, 2019

@nuclearsandwich sorry for the slow response, I somehow missed this, I'll reply to your questions.

@nuclearsandwich nuclearsandwich mentioned this pull request Jul 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@esteve @Karsten1987 @nuclearsandwich