Skip to content

Change how we install OpenSSL.#4343

Merged
clalancette merged 1 commit intorollingfrom
clalancette/win-openssl3
May 13, 2024
Merged

Change how we install OpenSSL.#4343
clalancette merged 1 commit intorollingfrom
clalancette/win-openssl3

Conversation

@clalancette
Copy link
Copy Markdown
Contributor

That's because v1.1.1, which we relied on for years, is no longer available from SLproweb. While we are here, we notice that it is actually possible to install OpenSSL 3.3.0 via chocolatey, which is significantly simpler for users.

We also need to update our CI to handle this; see ros2/ci#778 for that.

@clalancette clalancette added the backport-jazzy backport at reviewers discretion; from rolling to jazzy label May 1, 2024
@sotanakamura
Copy link
Copy Markdown

@clalancette clalancette force-pushed the clalancette/win-openssl3 branch from 8b125f6 to b1f11ac Compare May 13, 2024 16:34
@clalancette clalancette marked this pull request as ready for review May 13, 2024 16:34
@clalancette clalancette requested a review from audrow as a code owner May 13, 2024 16:34
@clalancette clalancette added backport-all backport at reviewers discretion; from rolling to all versions and removed backport-jazzy backport at reviewers discretion; from rolling to jazzy labels May 13, 2024
That's because v1.1.1, which we relied on for years, is
no longer available from SLproweb.  Instead, we install
it from chocolatey.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette force-pushed the clalancette/win-openssl3 branch from b1f11ac to ecb6146 Compare May 13, 2024 16:44
@clalancette clalancette merged commit 6bfe452 into rolling May 13, 2024
@clalancette clalancette deleted the clalancette/win-openssl3 branch May 13, 2024 17:17
mergify bot pushed a commit that referenced this pull request May 13, 2024
That's because v1.1.1, which we relied on for years, is
no longer available from SLproweb.  Instead, we install
it from chocolatey.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 6bfe452)
mergify bot pushed a commit that referenced this pull request May 13, 2024
That's because v1.1.1, which we relied on for years, is
no longer available from SLproweb.  Instead, we install
it from chocolatey.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 6bfe452)
mergify bot pushed a commit that referenced this pull request May 13, 2024
That's because v1.1.1, which we relied on for years, is
no longer available from SLproweb.  Instead, we install
it from chocolatey.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 6bfe452)
clalancette added a commit that referenced this pull request May 13, 2024
That's because v1.1.1, which we relied on for years, is
no longer available from SLproweb.  Instead, we install
it from chocolatey.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 6bfe452)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
clalancette added a commit that referenced this pull request May 13, 2024
That's because v1.1.1, which we relied on for years, is
no longer available from SLproweb.  Instead, we install
it from chocolatey.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 6bfe452)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
clalancette added a commit that referenced this pull request May 13, 2024
That's because v1.1.1, which we relied on for years, is
no longer available from SLproweb.  Instead, we install
it from chocolatey.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 6bfe452)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-all backport at reviewers discretion; from rolling to all versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants