Change how we install OpenSSL. (backport #4343)#4428
Merged
clalancette merged 1 commit intoironfrom May 13, 2024
Merged
Conversation
That's because v1.1.1, which we relied on for years, is no longer available from SLproweb. Instead, we install it from chocolatey. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 6bfe452)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That's because v1.1.1, which we relied on for years, is no longer available from SLproweb. While we are here, we notice that it is actually possible to install OpenSSL 3.3.0 via chocolatey, which is significantly simpler for users.
We also need to update our CI to handle this; see ros2/ci#778 for that.
This is an automatic backport of pull request #4343 done by Mergify.