Update to the commit for OpenSSL 3.3.0 on Windows.#778
Conversation
7fbbe65 to
7605f65
Compare
|
OK, all the fixes we need are on |
73ae83b to
1a7155f
Compare
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
1a7155f to
de178e6
Compare
|
Looking at the output of the test_security tests it's not clear that this is working as expected: I don't have a local setup to try it out but it might be worth checking on that exact setup if it's possible to establish secure communication between a talker and a listener |
While that is true, I will also say that is not different than the output in the nightlies, which show exactly the same thing. Also, trying out SROS2_Windows locally with OpenSSL 3.3.0 installed via chocolatey, everything seems to work for me. All of that leads me to believe that there may be a problem with the tests, but it is not new and is not caused by this change. |
👍 great thanks for testing locally!
😕 less great |
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
OK, due to problems between OpenSSL 3.3.0 and pycryptography 2.9.2 (which we still use on Windows Debug), we have to stick with OpenSSL 1.1.1. We can still get that from chocolatey, however, so we go ahead with that. Here is another omnibus set of Windows CI: |
|
All right, all CI is happy (or at least as happy as it gets on Windows right now). I'm going to go ahead and merge ros-infrastructure/ros2-cookbooks#68 , and then update the hash here to point to the latest there. |
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
See the description in ros-infrastructure/ros2-cookbooks#68 for more information on why we are doing this.