Switch to using OpenSSL from Chocolatey.#68
Merged
clalancette merged 10 commits intolatestfrom May 13, 2024
Merged
Conversation
This was referenced May 1, 2024
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
bd4f712 to
8dacb4e
Compare
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
nuclearsandwich
approved these changes
May 13, 2024
Contributor
Author
|
CI for this is over in ros2/ci#778 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial impetus to do this is because SLproweb no longer provides 1.1.1 packages. However, it turns out that chocolatey does provide packages for 3.3.0, so we can now simplify user's lives by using that. This means we can also remove the openssl recipe, since we just add it to the chocolatey stuff.
Due to a bug between cmake and these latest OpenSSL packages, we also need to update cmake to at least 3.29.2, so we also do that.