Added rmw_wait, rmw_create_wait_set and rmw_destroy_set tests#139
Merged
Added rmw_wait, rmw_create_wait_set and rmw_destroy_set tests#139
Conversation
…d tests Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
hidmic
reviewed
Sep 24, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
…plementation_wait_set
Contributor
Author
|
Signed-off-by: ahcorde <ahcorde@gmail.com>
Contributor
Author
|
hidmic
approved these changes
Sep 25, 2020
|
|
||
| // Created a valid wait set | ||
| rmw_wait_set_t * wait_set = rmw_create_wait_set(&context, 1); | ||
| ASSERT_NE(nullptr, wait_set); |
There was a problem hiding this comment.
@ahcorde nit:
Suggested change
| ASSERT_NE(nullptr, wait_set); | |
| ASSERT_NE(nullptr, wait_set) << rmw_get_error_string().str; |
Contributor
Author
|
|
@ros-pull-request-builder retest this please. |
|
@ahcorde ready to go! |
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
One last CI run:
|
|
Ok, this one's ready to go! I'll go ahead and merge. |
ahcorde
added a commit
that referenced
this pull request
Oct 9, 2020
…139) Signed-off-by: ahcorde <ahcorde@gmail.com> Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde
added a commit
that referenced
this pull request
Oct 9, 2020
…139) Signed-off-by: ahcorde <ahcorde@gmail.com> Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde
added a commit
that referenced
this pull request
Oct 21, 2020
…139) Signed-off-by: ahcorde <ahcorde@gmail.com> Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde
added a commit
that referenced
this pull request
Oct 21, 2020
…139) Signed-off-by: ahcorde <ahcorde@gmail.com> Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #137
Related to:
Signed-off-by: ahcorde ahcorde@gmail.com