This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Merged
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
hidmic
approved these changes
Sep 23, 2020
hidmic
left a comment
There was a problem hiding this comment.
LGTM, but before merging, would you mind opening a PR against rmw to add this error code to the API spec?
Contributor
Author
|
@hidmic it's already there, right? https://github.com/ros2/rmw/blob/master/rmw/include/rmw/ret_types.h#L34 |
|
It's defined in |
Signed-off-by: ahcorde <ahcorde@gmail.com>
hidmic
reviewed
Sep 24, 2020
|
I think the PR title needs clarification of what's being changed. |
Signed-off-by: ahcorde <ahcorde@gmail.com>
Contributor
Author
|
hidmic
approved these changes
Sep 25, 2020
|
CI up to
|
ahcorde
added a commit
that referenced
this pull request
Oct 9, 2020
* Updated rmw_*_*_allocation return codes Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed error codes in rmw_wait and rmw_destroy_wait Signed-off-by: ahcorde <ahcorde@gmail.com> * Used RMW_CHECK_ARGUMENT_FOR_NULL Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Oct 15, 2020
* Updated rmw_*_*_allocation return codes Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed error codes in rmw_wait and rmw_destroy_wait Signed-off-by: ahcorde <ahcorde@gmail.com> * Used RMW_CHECK_ARGUMENT_FOR_NULL Signed-off-by: ahcorde <ahcorde@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated return codes for unimplemented rmw___allocation functions. Related with this PR ros2/rmw_implementation#137
Signed-off-by: ahcorde ahcorde@gmail.com