Skip to content

Added rmw_publisher_allocation and rmw_subscription_allocation related tests#137

Merged
ahcorde merged 6 commits intomasterfrom
ahcorde/test/rmw_implementation
Sep 25, 2020
Merged

Added rmw_publisher_allocation and rmw_subscription_allocation related tests#137
ahcorde merged 6 commits intomasterfrom
ahcorde/test/rmw_implementation

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Sep 23, 2020

Added rmw_publisher_allocation and rmw_subscription_allocation related tests. This functions are unimplemented. Arguments inside the functions are all casted to void to avoid warnings.

Signed-off-by: ahcorde ahcorde@gmail.com

…d tests

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Sep 23, 2020

@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Sep 23, 2020

Build up-to test_rmw_implementation, this should only builds the other PRs. Testing test_rmw_implementation

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Copy link
Copy Markdown

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI, and after solving conflicts.

@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Sep 25, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic
Copy link
Copy Markdown

hidmic commented Sep 25, 2020

CI up to test_rmw_implementation and rcl, against all Tier 1 RMW implementations:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit b03ad4d into master Sep 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/test/rmw_implementation branch September 25, 2020 15:33
ahcorde added a commit that referenced this pull request Oct 9, 2020
…d tests (#137)

* Added rmw_publisher_allocation and rmw_subscription_allocation related tests

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Remove loaned message tests

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fix class name

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* make linters happy

Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Oct 21, 2020
…d tests (#137)

* Added rmw_publisher_allocation and rmw_subscription_allocation related tests

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Remove loaned message tests

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fix class name

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* make linters happy

Signed-off-by: ahcorde <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Failing or missing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants