Skip to content

Fix issues with resuming async tasks awaiting a future (backport #1469)#1582

Merged
fujitatomoya merged 4 commits intoros2:humblefrom
bjsowa:backport/humble/fix-async
Feb 26, 2026
Merged

Fix issues with resuming async tasks awaiting a future (backport #1469)#1582
fujitatomoya merged 4 commits intoros2:humblefrom
bjsowa:backport/humble/fix-async

Conversation

@bjsowa
Copy link
Copy Markdown
Contributor

@bjsowa bjsowa commented Jan 19, 2026 •
edited
Loading

Backport of #1469 (or #1560) to Humble

@bjsowa
Fix issues with resuming async tasks awaiting a future (backport ros2…
15c73ca 
…#1469)

Signed-off-by: Błażej Sowa <bsowa123@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Jan 19, 2026 •
edited
Loading

Pulls: #1582
Gist: https://gist.githubusercontent.com/ahcorde/2392bbe5553af486cf75cc86da38cf0a/raw/642d4261926461be8f3dc69f6817f9c15a1610b2/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17992

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@JWhitleyWork
Copy link
Copy Markdown

JWhitleyWork commented Jan 28, 2026

Thanks for getting this created! @ahcorde Any idea what's up with the RHEL build? It looks like rosbag2_py had some timeouts.

@JWhitleyWork
Copy link
Copy Markdown

JWhitleyWork commented Feb 14, 2026

Friendly ping of @ahcorde

@JWhitleyWork JWhitleyWork mentioned this pull request Feb 14, 2026
Open
@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Feb 14, 2026

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Feb 15, 2026

  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Feb 16, 2026

unfortunately many rclpy related tests are failing and reproducible. i do not think we can backport this to humble as it is...

@JWhitleyWork
Copy link
Copy Markdown

JWhitleyWork commented Feb 16, 2026

@bjsowa or @ahcorde Do either of you have time to address this?

@bjsowa
Copy link
Copy Markdown
Contributor Author

bjsowa commented Feb 16, 2026

@fujitatomoya Which rclpy-related tests are failing?

@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Feb 16, 2026

https://ci.ros2.org/job/ci_linux-rhel/7544/testReport/ and https://ci.ros2.org/job/ci_windows/26685/testReport/

@bjsowa
Copy link
Copy Markdown
Contributor Author

bjsowa commented Feb 19, 2026

The failing test on Windows CI does not seem related to this PR: https://ci.ros2.org/job/ci_windows/26685/testReport/(root)/rclpy/test_python_allocator_gtest_missing_result/

@bjsowa
Copy link
Copy Markdown
Contributor Author

bjsowa commented Feb 19, 2026

RHEL is failing because it cannot import dataclasses (dataclasses were added in Python 3.7 and RHEL 8 is using Python 3.6). I'll try to drop the usage of dataclasses module.

@bjsowa bjsowa force-pushed the backport/humble/fix-async branch from 8a978f9 to 0a07220 Compare February 19, 2026 11:05
@bjsowa
Drop the usage of dataclasses for Python 3.6 compatibility
e56af99 
Signed-off-by: Błażej Sowa <bsowa123@gmail.com>
@bjsowa bjsowa force-pushed the backport/humble/fix-async branch from 0a07220 to e56af99 Compare February 19, 2026 11:14
@bjsowa
Copy link
Copy Markdown
Contributor Author

bjsowa commented Feb 19, 2026

@fujitatomoya Could you run the CI now?

fujitatomoya
fujitatomoya approved these changes Feb 19, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI.

@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Feb 19, 2026

Pulls: #1582
Gist: https://gist.githubusercontent.com/fujitatomoya/7a4aac940b6cbf60c5fad36f39f8ae69/raw/7b8a868323fc6d01817882ac88533b7cc81dc27e/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18268

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Feb 19, 2026

Note

Once this is merged, rebase #1605 and run CI there.

@bjsowa bjsowa force-pushed the backport/humble/fix-async branch from c162d5e to 065530d Compare February 20, 2026 09:26
@bjsowa
Copy link
Copy Markdown
Contributor Author

bjsowa commented Feb 20, 2026

@fujitatomoya Linux, Linux-aarch64 and Windows CI did not pass flake8 test because I used wrong type of quotes. Kinda weird that it wasn't caught by pr job or when I run the tests locally but I fixed it now.

RHEL CI is failing on build stage due to ros2-rust/rosidl_rust#12 (another python 3.6 compatibility issue)

@bjsowa
Use single instead of double quotes
155199a 
Signed-off-by: Błażej Sowa <bsowa123@gmail.com>
@bjsowa bjsowa force-pushed the backport/humble/fix-async branch from 065530d to 155199a Compare February 20, 2026 10:00
@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Feb 21, 2026

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@bjsowa
Copy link
Copy Markdown
Contributor Author

bjsowa commented Feb 23, 2026

@fujitatomoya The remaining test failures do not seem related to rclpy.

@JWhitleyWork
Copy link
Copy Markdown

JWhitleyWork commented Feb 26, 2026

@fujitatomoya Can we get a merge when you have a minute?

@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Feb 26, 2026

@bjsowa @JWhitleyWork thanks! merging!

@fujitatomoya fujitatomoya merged commit 050145e into ros2:humble Feb 26, 2026
3 checks passed
@bjsowa bjsowa mentioned this pull request Mar 2, 2026
Merged
@JWhitleyWork
Copy link
Copy Markdown

JWhitleyWork commented Mar 9, 2026

@ahcorde Would you be able to make a new release of humble? This PR is waiting on a release.

@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Mar 9, 2026

@JWhitleyWork done here ros/rosdistro#50187

@JWhitleyWork
Copy link
Copy Markdown

JWhitleyWork commented Mar 9, 2026

@JWhitleyWork done here ros/rosdistro#50187

Thank you!

@ros-discourse
Copy link
Copy Markdown

ros-discourse commented Mar 16, 2026

This pull request has been mentioned on Open Robotics Discourse. There might be relevant details there:

https://discourse.openrobotics.org/t/new-humble-sync/53277/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bjsowa @ahcorde @JWhitleyWork @fujitatomoya @ros-discourse