Prevents the Future result from being set twice. (backport #1599)#1605
Prevents the Future result from being set twice. (backport #1599)#1605mergify[bot] wants to merge 1 commit intohumblefrom
Conversation
|
Cherry-pick of a348801 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
This backport didn't apply because #1582 needs to be merged first. @fujitatomoya Can you apply this change to that PR? |
|
@JWhitleyWork thanks for pointing that out 👍 let's go step by step to keep the git history. i just started CI on #1582, and let's merge it 1st. and then we can get back to this PR. |
|
@Mergifyio rebase humble |
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Nadav Elkabets <elnadav12@gmail.com> (cherry picked from commit a348801) # Conflicts: # rclpy/rclpy/action/server.py
✅ Branch has been successfully rebased |
6f0a360 to
17d43fc
Compare
|
@JWhitleyWork the base code is different from upstream, we should close this? |
|
I will test to see if #1598 exists on the |
|
This class doesn't even appear to have the functions necessary to support this fix so I think this can be closed. |
Description
Fixes #1598
Is this user-facing behavior change?
Yes, but this fixes the behavior that has been changed by #1469
Did you use Generative AI?
Yes, Copilot Claude Sonnet 4.5
Additional Information
This is an automatic backport of pull request #1599 done by [Mergify](https://mergify.com).