Prevents the Future result from being set twice.#1599
Merged
fujitatomoya merged 1 commit intorollingfrom Feb 4, 2026
Merged
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Nadav Elkabets <elnadav12@gmail.com>
e2666eb to
5e95dc8
Compare
fujitatomoya
commented
Feb 4, 2026
Collaborator
Author
fujitatomoya
left a comment
There was a problem hiding this comment.
this patch is created because of #1469, but i think this is generic fix to all the downstream distros.
ahcorde
approved these changes
Feb 4, 2026
Contributor
|
Pulls: #1599
|
nadavelkabets
approved these changes
Feb 4, 2026
Collaborator
Author
|
Collaborator
Author
|
@Mergifyio backport kilted jazzy humble |
Contributor
✅ Backports have been createdDetails
Cherry-pick of a348801 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
mergify bot
pushed a commit
that referenced
this pull request
Feb 4, 2026
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Nadav Elkabets <elnadav12@gmail.com> (cherry picked from commit a348801)
mergify bot
pushed a commit
that referenced
this pull request
Feb 4, 2026
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Nadav Elkabets <elnadav12@gmail.com> (cherry picked from commit a348801)
mergify bot
pushed a commit
that referenced
this pull request
Feb 4, 2026
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Nadav Elkabets <elnadav12@gmail.com> (cherry picked from commit a348801) # Conflicts: # rclpy/rclpy/action/server.py
ahcorde
pushed a commit
that referenced
this pull request
Feb 5, 2026
ahcorde
pushed a commit
that referenced
this pull request
Feb 6, 2026
fujitatomoya
added a commit
that referenced
this pull request
Feb 26, 2026
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Nadav Elkabets <elnadav12@gmail.com> (cherry picked from commit a348801) # Conflicts: # rclpy/rclpy/action/server.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1598
Is this user-facing behavior change?
Yes, but this fixes the behavior that has been changed by #1469
Did you use Generative AI?
Yes, Copilot Claude Sonnet 4.5
Additional Information