[eloquent backport] Remove absolute path from installed CMake code (#948)#950
Merged
jacobperron merged 1 commit intoeloquentfrom Jan 17, 2020
Merged
[eloquent backport] Remove absolute path from installed CMake code (#948)#950jacobperron merged 1 commit intoeloquentfrom
jacobperron merged 1 commit intoeloquentfrom
Conversation
Otherwise, rclcpp_components_register_node() fails if used from a fat archive. Related to ros2/ros2#606. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
Author
|
@ros-pull-request-builder retest this please |
mjcarroll
approved these changes
Jan 14, 2020
Member
Author
|
Test failures appear unrelated. Merging. |
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
The PLUGINLIB_DISABLE_BOOST define hasn't been honored (or even available) in close to 2 years now, so just remove it from the build. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #948 to Eloquent
Otherwise, rclcpp_components_register_node() fails if used from a fat archive.