Merged
Conversation
mikaelarguedas
approved these changes
Feb 24, 2018
Member
mikaelarguedas
left a comment
There was a problem hiding this comment.
lgtm
Did you try to build it statically ?
wjwwood
approved these changes
Feb 24, 2018
Member
wjwwood
left a comment
There was a problem hiding this comment.
lgtm, but should ament_export_dependencies(ament_cmake) be changed or removed? I'm honestly not sure if it should be exported or not.
Member
Author
|
no, didn't try to build it statically
|
Member
Author
|
since I didn't build it statically I connected this to ros2/ros2#306 in place of #390 so the changes are visible when people are testing that ticket |
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
Signed-off-by: Abby Xu <abbyxu@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revival of #390
Connects to ros2/ros2#306 but hasn't been tested with static linking ourselves
rmwdependency addition that seemed unrelatedrclcpp_lifecycleexec_depending onament_cmaketoament_cmake_rosbecause from this PR I inferred the dependency is fornormalize_pathfromament_cmakeitself.