Control shared/static linking via BUILD_SHARED_LIBS#390
Closed
esteve wants to merge 1 commit intoros2:masterfrom
Closed
Control shared/static linking via BUILD_SHARED_LIBS#390esteve wants to merge 1 commit intoros2:masterfrom
esteve wants to merge 1 commit intoros2:masterfrom
Conversation
lmayencourt
approved these changes
Oct 27, 2017
dirk-thomas
reviewed
Oct 27, 2017
| ament_target_dependencies(${PROJECT_NAME} | ||
| "builtin_interfaces" | ||
| "rcl" | ||
| "rmw" |
Member
There was a problem hiding this comment.
Can you please elaborate why rmw was added here as well as it being exported.
Merged
Member
Author
Member
|
didn't mean to shut down the conversation in this thread @esteve; if there are dependencies on |
Member
Author
|
@dhood sorry I hope I didn't sound harsh, I didn't mean at all. I honestly wanted to thank you for fleshing out this PR, I had totally forgotten about it. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not ready for review, just submitted this so that it's added to ros2/ros2#306