Skip to content

Call LaunchROSTestModule with the new API.#150

Merged
clalancette merged 1 commit intomasterfrom
fix-launch-warnings
May 14, 2020
Merged

Call LaunchROSTestModule with the new API.#150
clalancette merged 1 commit intomasterfrom
fix-launch-warnings

Conversation

@clalancette
Copy link
Copy Markdown
Contributor

@clalancette clalancette commented May 14, 2020

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

This goes along with ros2/launch#421 (and the CI is over there as well).

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette clalancette requested a review from hidmic May 14, 2020 13:50
Copy link
Copy Markdown

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI goes green

@clalancette clalancette merged commit 2e64ea5 into master May 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-launch-warnings branch May 14, 2020 16:15
sloretz pushed a commit that referenced this pull request Sep 8, 2020
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
sloretz added a commit that referenced this pull request Sep 8, 2020
… Call LaunchROSTestModule with the new API. (#150)  (#176)

* avoid deprecation warning, use from_parent (#141)

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Call LaunchROSTestModule with the new API. (#150)

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants