Skip to content

[backport humble] Implement Any, All, Equals, and NotEquals substitutions (#649)#871

Merged
christophebedard merged 3 commits intoros2:humblefrom
emersonknapp:backport-649-humble
May 18, 2025
Merged

[backport humble] Implement Any, All, Equals, and NotEquals substitutions (#649)#871
christophebedard merged 3 commits intoros2:humblefrom
emersonknapp:backport-649-humble

Conversation

@emersonknapp
Copy link
Contributor

@emersonknapp emersonknapp commented May 1, 2025 •
edited
Loading

Backport #649 to humble

Depends on #872

@emersonknapp emersonknapp mentioned this pull request May 1, 2025
Merged
@christophebedard
Copy link
Member

christophebedard commented May 2, 2025

Note that #864 backports some of this, looks like it will get merged soon.

christophebedard
christophebedard reviewed May 2, 2025
View reviewed changes
@emersonknapp emersonknapp mentioned this pull request May 5, 2025
Closed
methylDragon and others added 2 commits May 6, 2025 09:07
@methylDragon @jacobperron @emersonknapp
Implement Any, All, Equals, and NotEquals substitutions (ros2#649)
03df498 
* Implement Any and All substitutions

Signed-off-by: methylDragon <methylDragon@gmail.com>

* Implement Equals and NotEquals substitutions

Signed-off-by: methylDragon <methylDragon@gmail.com>

* Implement stringification for equality substitutions

Signed-off-by: methylDragon <methylDragon@gmail.com>

* Fix tests

Signed-off-by: methylDragon <methylDragon@gmail.com>

* Use type utils and add to docstrings

Signed-off-by: methylDragon <methylDragon@gmail.com>

* Check for substitutions on init in Equals substitution

Signed-off-by: methylDragon <methylDragon@gmail.com>

* Fix flake8 errors

Signed-off-by: methylDragon <methylDragon@gmail.com>

* Fix typo in self-description

Signed-off-by: methylDragon <methylDragon@gmail.com>

Co-authored-by: Jacob Perron <jacob@openrobotics.org>

Signed-off-by: methylDragon <methylDragon@gmail.com>
Co-authored-by: Jacob Perron <jacob@openrobotics.org>
@emersonknapp
Back out deprecation notices, in backport
0dc02f4 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp emersonknapp force-pushed the backport-649-humble branch from c38e45c to 0dc02f4 Compare May 6, 2025 16:07
@emersonknapp
Copy link
Contributor Author

emersonknapp commented May 6, 2025

Rebased to latest humble now that dependent PR merged

@emersonknapp
Copy link
Contributor Author

emersonknapp commented May 14, 2025

Pulls: #871
Gist: https://gist.githubusercontent.com/emersonknapp/b7c0881ee054be868fdbc66c070edc2d/raw/42d1cf75b004539de032bf4cd47a72be76ddb490/ros2.repos
BUILD args: --packages-above-and-dependencies launch
TEST args: --packages-above launch
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15994

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

christophebedard
christophebedard requested changes May 15, 2025
View reviewed changes
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one linter fix.

@emersonknapp @christophebedard
Update launch/launch/conditions/launch_configuration_equals.py
318d4b5 
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com>
@emersonknapp
Copy link
Contributor Author

emersonknapp commented May 16, 2025 •
edited by christophebedard
Loading

Pulls: #871
Gist: https://gist.githubusercontent.com/emersonknapp/abc8cc0c0244b0d0f7b033775e1187f6/raw/42d1cf75b004539de032bf4cd47a72be76ddb490/ros2.repos
BUILD args: --packages-above-and-dependencies launch
TEST args: --packages-above launch
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16006

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@emersonknapp emersonknapp moved this to In review in Robograph Planning May 16, 2025
@christophebedard
Copy link
Member

christophebedard commented May 16, 2025

I retriggered the RHEL job, but we should make sure it's the right job number once it actually starts running

@suchetanrs suchetanrs mentioned this pull request May 17, 2025
Merged
7 tasks
@emersonknapp
Copy link
Contributor Author

emersonknapp commented May 17, 2025

@christophebedard looks like it's good! It was the right job number. The issues seem common to RHEL jobs on Humble already, see for example https://ci.ros2.org/job/ci_linux-rhel/2891/#showFailuresLink

@christophebedard christophebedard merged commit d419d4a into ros2:humble May 18, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Robograph Planning May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christophebedard christophebedard christophebedard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emersonknapp @christophebedard @methylDragon