Implement Any, All, Equals, and NotEquals substitutions#649
Merged
methylDragon merged 8 commits intorollingfrom Sep 28, 2022
Merged
Implement Any, All, Equals, and NotEquals substitutions#649methylDragon merged 8 commits intorollingfrom
methylDragon merged 8 commits intorollingfrom
Conversation
87ffd90 to
9b6ec09
Compare
bf6a6a7 to
9ac1ec2
Compare
jacobperron
reviewed
Sep 13, 2022
jacobperron
reviewed
Sep 13, 2022
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
9ac1ec2 to
df20be6
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
df20be6 to
bec6745
Compare
Contributor
Author
|
Signed-off-by: methylDragon <methylDragon@gmail.com>
f9b4488 to
f34b2e5
Compare
Contributor
Author
|
Flake8 errors. Let's try this again:
|
Contributor
Author
|
Windows failures seem unrelated, but I'm gonna try again regardless
|
jacobperron
approved these changes
Sep 28, 2022
Member
jacobperron
left a comment
There was a problem hiding this comment.
I have one minor unresolved comment above, otherwise LGTM!
Signed-off-by: methylDragon <methylDragon@gmail.com> Co-authored-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
Oct 4, 2022
The LaunchConfigurationEquals and LaunchConfigurationNotEquals conditions were deprecated in #649. This change captures the expected warnings in their unit tests. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
Oct 5, 2022
The LaunchConfigurationEquals and LaunchConfigurationNotEquals conditions were deprecated in #649. This change captures the expected warnings in their unit tests. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
emersonknapp
pushed a commit
to emersonknapp/launch
that referenced
this pull request
May 1, 2025
* Implement Any and All substitutions Signed-off-by: methylDragon <methylDragon@gmail.com> * Implement Equals and NotEquals substitutions Signed-off-by: methylDragon <methylDragon@gmail.com> * Implement stringification for equality substitutions Signed-off-by: methylDragon <methylDragon@gmail.com> * Fix tests Signed-off-by: methylDragon <methylDragon@gmail.com> * Use type utils and add to docstrings Signed-off-by: methylDragon <methylDragon@gmail.com> * Check for substitutions on init in Equals substitution Signed-off-by: methylDragon <methylDragon@gmail.com> * Fix flake8 errors Signed-off-by: methylDragon <methylDragon@gmail.com> * Fix typo in self-description Signed-off-by: methylDragon <methylDragon@gmail.com> Co-authored-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: methylDragon <methylDragon@gmail.com> Co-authored-by: Jacob Perron <jacob@openrobotics.org>
emersonknapp
pushed a commit
to emersonknapp/launch
that referenced
this pull request
May 6, 2025
* Implement Any and All substitutions Signed-off-by: methylDragon <methylDragon@gmail.com> * Implement Equals and NotEquals substitutions Signed-off-by: methylDragon <methylDragon@gmail.com> * Implement stringification for equality substitutions Signed-off-by: methylDragon <methylDragon@gmail.com> * Fix tests Signed-off-by: methylDragon <methylDragon@gmail.com> * Use type utils and add to docstrings Signed-off-by: methylDragon <methylDragon@gmail.com> * Check for substitutions on init in Equals substitution Signed-off-by: methylDragon <methylDragon@gmail.com> * Fix flake8 errors Signed-off-by: methylDragon <methylDragon@gmail.com> * Fix typo in self-description Signed-off-by: methylDragon <methylDragon@gmail.com> Co-authored-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: methylDragon <methylDragon@gmail.com> Co-authored-by: Jacob Perron <jacob@openrobotics.org>
christophebedard
added a commit
that referenced
this pull request
May 18, 2025
…ions (#649) (#871) Signed-off-by: methylDragon <methylDragon@gmail.com> Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> Signed-off-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com> Co-authored-by: methylDragon <methylDragon@gmail.com> Co-authored-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements new
AnyandAllboolean substitutions. As well as newEqualsandNotEqualssubstitutions.The equality substitutions deprecate the
LaunchConfigurationEqualsandLaunchConfigurationNotEqualsconditions, because they're more universal and can take inLaunchConfigurationsubstitutions.It should be self-explanatory from the included tests (: