Backport the equals and not equals substitutions#864
Backport the equals and not equals substitutions#864suchetanrs wants to merge 1 commit intoros2:humblefrom
Conversation
Signed-off-by: suchetanrs <suchetan.saravanan@gmail.com>
|
@christophebedard can we get a review and CI job for this? |
|
Pulls: #864
|
There was a problem hiding this comment.
Looks good to me.
It's useful to link to the original PR in the PR description when making a backport: #649 (partial backport in this case).
|
|
I don't want to devalue effort that @suchetanrs has put in, but I also want to maintain branch cohesion as much as possible so that future backports remain easier. I might suggest we go with #871 instead of this PR, it is a complete cherry-pick backport of the original contribution. It backports the same substitutions but also the Either that or I can follow up with #871 to fill in the remaining features that weren't backported here. |
|
It's up to you guys |
|
I agree with @emersonknapp that #871 is a full backport and is more feature complete than this PR. Please feel free to prefer #871 instead of this if the need be. |
|
Then I will close this PR, thank you! |
Hello,
This PR backports the equals and not equals substitutions to humble along with their tests.
Update:
More information:
This is a backport of the PR #649