Skip to content

[Eloquent backport] stop using constructors deprecated in pytest 5.4 (#391) Switch to from_parent (partial #421) avoid deprecation warning, use from_parent (#402)#459

Merged
sloretz merged 3 commits intoeloquentfrom
eloquent_backport_391
Sep 8, 2020
Merged

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Sep 8, 2020 •
edited
Loading

Cherry pick of #391 - checking if this fixes #458

Now also includes a cherry-pick of one commit from #421: f1c02f3

Now also includes a cherry-pick of #402

@rotu @sloretz
stop using constructors deprecated in pytest 5.4 (#391)
0d4d8dc 
Signed-off-by: Dan Rose <dan@digilabs.io>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz self-assigned this Sep 8, 2020
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Sep 8, 2020

Linux CI
Build Status

@clalancette @sloretz
Switch to from_parent to remove deprecation warning.
5c8981e 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz changed the title [Eloquent backport] stop using constructors deprecated in pytest 5.4 (#391) [Eloquent backport] stop using constructors deprecated in pytest 5.4 (#391) Switch to from_parent (partial #421) Sep 8, 2020
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Sep 8, 2020

Linux CI after adding partial cherry-pick of #421 Build Status

@dirk-thomas @sloretz
avoid deprecation warning, use from_parent (#402)
a790417 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz changed the title [Eloquent backport] stop using constructors deprecated in pytest 5.4 (#391) Switch to from_parent (partial #421) [Eloquent backport] stop using constructors deprecated in pytest 5.4 (#391) Switch to from_parent (partial #421) avoid deprecation warning, use from_parent (#402) Sep 8, 2020
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Sep 8, 2020

Linux CI after adding cherry-pick of #402 Build Status

@mjcarroll
Copy link
Copy Markdown
Member

mjcarroll commented Sep 8, 2020

Supercedes #447

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Sep 8, 2020

CI (build: --packages-up-to launch_testing ros2action test: --packages-select launch_testing ros2action ... picked ros2action since it's one of the packages that also showed this deprecation warning by using launch_testing)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz mentioned this pull request Sep 8, 2020
Merged
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Sep 8, 2020

CI including ros2/launch_ros#176 ( build: --packages-up-to launch_testing launch_testing_ros ros2action ros2interface ros2lifecycle ros2msg ros2node ros2pkg ros2service ros2srv ros2test ros2topic test: --packages-select launch_testing launch_testing_ros ros2action ros2interface ros2lifecycle ros2msg ros2node ros2pkg ros2service ros2srv ros2test ros2topic ... that's all packages that are failing in the Eloquent nightlies)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Sep 8, 2020

CI looks ok, I think. There's no good build to compare the arm/OSX/Windows builds to, but none of the test failures appear related to this PR. The linux ones all seem to be an unrelated error: AttributeError: module 'pycodestyle' has no attribute 'break_around_binary_operator', which might have to do with a mismatch in the version of pycodestyle and flake8: https://gitlab.com/pycqa/flake8/-/issues/427 ? There's also a couple pep257 test failures for existing doc strings.

@sloretz sloretz merged commit b750eda into eloquent Sep 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the eloquent_backport_391 branch September 8, 2020 23:27
@mjcarroll mjcarroll mentioned this pull request Sep 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees

@sloretz sloretz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sloretz @mjcarroll @rotu @clalancette @dirk-thomas