avoid deprecation warning, use from_parent#402
Merged
dirk-thomas merged 1 commit intomasterfrom Apr 16, 2020
Merged
Conversation
04ff553 to
b322fec
Compare
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
b322fec to
e539577
Compare
sloretz
pushed a commit
that referenced
this pull request
Sep 8, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
sloretz
added a commit
that referenced
this pull request
Sep 8, 2020
…391) Switch to from_parent (partial #421) avoid deprecation warning, use from_parent (#402) (#459) * stop using constructors deprecated in pytest 5.4 (#391) Signed-off-by: Dan Rose <dan@digilabs.io> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Switch to from_parent to remove deprecation warning. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * avoid deprecation warning, use from_parent (#402) Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Dan Rose <rotu@users.noreply.github.com> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI builds are testing
launch_testingandlaunch_testing_ros(with only FastRTPS) which both show the deprecation warnings in the latest builds.Warnings before: https://ci.ros2.org/job/ci_linux/10241/
After: