stop using constructors deprecated in pytest 5.4#391
Merged
ivanpauno merged 2 commits intoros2:masterfrom Mar 18, 2020
Merged
Conversation
Contributor
rotu
commented
Mar 13, 2020
```
=============================== warnings summary ===============================
/opt/ros/master/install/lib/python3.8/site-packages/launch_testing/pytest/hooks.py:113
/opt/ros/master/install/lib/python3.8/site-packages/launch_testing/pytest/hooks.py:113
/opt/ros/master/install/lib/python3.8/site-packages/launch_testing/pytest/hooks.py:113: PytestDeprecationWarning: direct construction of Package has been deprecated, please use Package.from_parent
return pytest.Package(path, parent)
/opt/ros/master/install/lib/python3.8/site-packages/launch_testing/pytest/hooks.py:114: 37 tests with warnings
/opt/ros/master/install/lib/python3.8/site-packages/launch_testing/pytest/hooks.py:114: PytestDeprecationWarning: direct construction of Module has been deprecated, please use Module.from_parent
return pytest.Module(path, parent)
-- Docs: https://docs.pytest.org/en/latest/warnings.html
================= 324 passed, 39 warnings in 66.09s (0:01:06) ==================
```
Signed-off-by: Dan Rose <dan@digilabs.io>
ivanpauno
approved these changes
Mar 16, 2020
Member
ivanpauno
left a comment
There was a problem hiding this comment.
Some minimal comments, otherwise LGTM!
Member
|
@rotu friendly ping. |
Signed-off-by: Dan Rose <dan@digilabs.io>
Contributor
Author
Thanks! I left my Linux box at the office and forgot to push before I went into self-quarantine. I grabbed the computer, sterilized this commit, and pushed. |
ivanpauno
approved these changes
Mar 18, 2020
Member
|
Member
🤣 |
Member
|
Failure is unrelated, see ros2/launch_ros#128 (comment). |
mjcarroll
pushed a commit
that referenced
this pull request
Aug 7, 2020
Signed-off-by: Dan Rose <dan@digilabs.io>
sloretz
pushed a commit
that referenced
this pull request
Sep 8, 2020
Signed-off-by: Dan Rose <dan@digilabs.io> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
sloretz
added a commit
that referenced
this pull request
Sep 8, 2020
…391) Switch to from_parent (partial #421) avoid deprecation warning, use from_parent (#402) (#459) * stop using constructors deprecated in pytest 5.4 (#391) Signed-off-by: Dan Rose <dan@digilabs.io> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Switch to from_parent to remove deprecation warning. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * avoid deprecation warning, use from_parent (#402) Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Dan Rose <rotu@users.noreply.github.com> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.