Skip to content

Move geometry_msgs/PoseStampedArray to nav_msgs/Goals#269

Merged
tfoote merged 2 commits intorollingfrom
nav_msgs_goals
Mar 3, 2025
Merged

Move geometry_msgs/PoseStampedArray to nav_msgs/Goals#269
tfoote merged 2 commits intorollingfrom
nav_msgs_goals

Conversation

@tfoote
Copy link
Contributor

@tfoote tfoote commented Feb 18, 2025

Fixes #267

Fixes #267

Signed-off-by: Tully Foote <tullyfoote@intrinsic.ai>
Signed-off-by: Tully Foote <tullyfoote@intrinsic.ai>
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-pmc-meeting-minutes-2025-01-18/42127/1

@mjcarroll
Copy link
Member

Pulls: #269
Gist: https://gist.githubusercontent.com/mjcarroll/eeeb104c3c2d1af1f53df736dcd949cb/raw/c0fd1b9edd8c6beda85acb562794b49860c3b4d0/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15260

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@tfoote
Copy link
Contributor Author

tfoote commented Mar 3, 2025

2 Windows test failures in ament_mypy are in a completely unrelated package that's not a dependency. It looks like a toolchain version missmatch?

C:\Python38\lib\site-packages\_pytest\runner.py:311: in from_call
    result: Optional[TResult] = func()
C:\Python38\lib\site-packages\_pytest\runner.py:255: in <lambda>
    lambda: ihook(item=item, **kwds), when=when, reraise=reraise
C:\Python38\lib\site-packages\pluggy\_hooks.py:513: in __call__
    return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
C:\Python38\lib\site-packages\pluggy\_manager.py:120: in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
C:\Python38\lib\site-packages\_pytest\runner.py:150: in pytest_runtest_setup
    item.session._setupstate.prepare(item)
C:\Python38\lib\site-packages\_pytest\runner.py:447: in prepare
    self.stack.append(col)
E   AttributeError: 'dict' object has no attribute 'append'

https://ci.ros2.org/job/ci_windows/23413/testReport/ament_mypy.test/test_mypy/test_mypy/

And rosbag2 has a header compile warning: player_progress_bar.hpp:91 [C4251](https://ci.ros2.org/job/ci_windows/23413/msbuild/folder.-1996843695/category.63474781/)

And Build Tools? has a casting issue memory:3381 [C4267](https://ci.ros2.org/job/ci_windows/23413/msbuild/folder.267693166/category.63474818/) [Normal](https://ci.ros2.org/job/ci_windows/23413/msbuild/folder.267693166/NORMAL) 1 'argument': conversion from 'size_t' to 'int32_t', possible loss of data

I reran and saw that the errors were consistent: * Windows Build Status

I reran this removing the local changes and confirmed that the errors still exist:

  • Windows baseline without changes Build Status

@tfoote tfoote merged commit 3ad2c92 into rolling Mar 3, 2025
3 checks passed
@tfoote tfoote deleted the nav_msgs_goals branch March 3, 2025 08:06
@tfoote
Copy link
Contributor Author

tfoote commented Mar 3, 2025

@SteveMacenski
Copy link
Contributor

Migration ticket for Nav2 made: ros-navigation/navigation2#4976

Sushant-Chavan pushed a commit to Sushant-Chavan/common_interfaces that referenced this pull request Mar 17, 2025
* Move geometry_msgs/PoseStampedArray to nav_msgs/Goals
Fixes ros2#267

Signed-off-by: Tully Foote <tullyfoote@intrinsic.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposed rename of geometry_msgs/PoseStampedArray to nav_msgs/Goals

4 participants