Skip to content

πŸ§‘β€πŸŒΎ rosbag2_transport windows warningsΒ #1926

@Crola1702

Description

@Crola1702

Reference builds:

Msbuild warnings:

  player_progress_bar.cpp

  Defining YAML_CPP_API for DLL import

C:\ci\ws\src\ros2\rosbag2\rosbag2_transport\include\rosbag2_transport/player_progress_bar.hpp(91,42): warning C4251: 'rosbag2_transport::PlayerProgressBar::pimpl_': class 'std::unique_ptr<rosbag2_transport::PlayerProgressBarImpl,std::default_delete<rosbag2_transport::PlayerProgressBarImpl>>' needs to have dll-interface to be used by clients of class 'rosbag2_transport::PlayerProgressBar' (compiling source file C:\ci\ws\src\ros2\rosbag2\rosbag2_transport\src\rosbag2_transport\player_progress_bar.cpp) [C:\ci\ws\build\rosbag2_transport\rosbag2_transport.vcxproj]

C:\ci\ws\src\ros2\rosbag2\rosbag2_transport\include\rosbag2_transport/player_progress_bar.hpp(91): message : see declaration of 'std::unique_ptr<rosbag2_transport::PlayerProgressBarImpl,std::default_delete<rosbag2_transport::PlayerProgressBarImpl>>' (compiling source file C:\ci\ws\src\ros2\rosbag2\rosbag2_transport\src\rosbag2_transport\player_progress_bar.cpp) [C:\ci\ws\build\rosbag2_transport\rosbag2_transport.vcxproj]

  Defining YAML_CPP_API for DLL import

  player_service_client.cpp

C:\ci\ws\src\ros2\rosbag2\rosbag2_transport\include\rosbag2_transport/player_progress_bar.hpp(91,42): warning C4251: 'rosbag2_transport::PlayerProgressBar::pimpl_': class 'std::unique_ptr<rosbag2_transport::PlayerProgressBarImpl,std::default_delete<rosbag2_transport::PlayerProgressBarImpl>>' needs to have dll-interface to be used by clients of class 'rosbag2_transport::PlayerProgressBar' (compiling source file C:\ci\ws\src\ros2\rosbag2\rosbag2_transport\src\rosbag2_transport\player.cpp) [C:\ci\ws\build\rosbag2_transport\rosbag2_transport.vcxproj]

C:\ci\ws\src\ros2\rosbag2\rosbag2_transport\include\rosbag2_transport/player_progress_bar.hpp(91): message : see declaration of 'std::unique_ptr<rosbag2_transport::PlayerProgressBarImpl,std::default_delete<rosbag2_transport::PlayerProgressBarImpl>>' (compiling source file C:\ci\ws\src\ros2\rosbag2\rosbag2_transport\src\rosbag2_transport\player.cpp) [C:\ci\ws\build\rosbag2_transport\rosbag2_transport.vcxproj]

...

C:\ci\ws\src\ros2\rosbag2\rosbag2_transport\include\rosbag2_transport/player_progress_bar.hpp(91): message : see declaration of 'std::unique_ptr<rosbag2_transport::PlayerProgressBarImpl,std::default_delete<rosbag2_transport::PlayerProgressBarImpl>>' [C:\ci\ws\build\rosbag2_transport\test_player_progress_bar.vcxproj]

C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\include\memory(3381,59): warning C4267: 'argument': conversion from 'size_t' to 'int32_t', possible loss of data [C:\ci\ws\build\rosbag2_transport\test_player_progress_bar.vcxproj]

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions