Switch to C++17 for SIP and Shiboken#135
Merged
clalancette merged 1 commit intoros-visualization:rollingfrom Feb 23, 2024
Merged
Conversation
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
This was referenced Feb 22, 2024
Contributor
|
Here's CI with just this PR in place:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to ros-visualization/qt_gui_core#288
Relates to ros/pluginlib#254
Switch to C++17 to be able to use
std::filesystemwhen building SIP or Shiboken bindings.I'm doing this mainly for
qt_gui_coreand I didn't seem to need the change for Shiboken, but we'll probably hit the same issue as we migrate everything else to C++17'sstd::filesystem. See the corresponding docs for Shiboken: https://doc.qt.io/qtforpython-5/shiboken2/shibokengenerator.html#usage.I think we can merge this without negatively affecting anything.